Bug 2318062 - Review Request: rust-ansi-to-tui - Library to convert ansi color coded text into ratatui::text::Text type from ratatui library
Summary: Review Request: rust-ansi-to-tui - Library to convert ansi color coded text i...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 41
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Cristian Le
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2310209
TreeView+ depends on / blocked
 
Reported: 2024-10-11 15:39 UTC by solomoncyj
Modified: 2025-05-21 00:27 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-05-21 00:27:35 UTC
Type: ---
Embargoed:
fedora: fedora-review?


Attachments (Terms of Use)

Description solomoncyj 2024-10-11 15:39:19 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-40-x86_64/08125627-rust-ansi-to-tui/rust-ansi-to-tui.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-40-x86_64/08125627-rust-ansi-to-tui/rust-ansi-to-tui-6.0.0-1.fc40.src.rpm
Description: Library to convert ansi color coded text into ratatui::text::Text type from ratatui library
Fedora Account System Username: solomoncyj

Reproducible: Always

Comment 1 Cristian Le 2024-10-23 15:38:32 UTC
The link is 404ed, but I am giving some preliminary comments based on your current GH repo status. A few things to change:
- Don't change the description inside of `Cargo.toml`
- The rpm description should be fine as it was
- The summary seems grammatically incomplete. Maybe add a `into ratatui` or `for ratatui`
- `criterion` is something you will have to constantly patch. Try using something like:
```
[requires]
build = [
    "tomcli",
]

[scripts.prep]
post = [
    "# Do not depend on criterion; it is needed only for benchmarks.",
    "tomcli set Cargo.toml del dev-dependencies.criterion",
]
```
- There are a few unnecessary files being included in the `devel` package which would be nice to have removed: `flake.*`
  You can just add an additional `rm` line in the `scripts.prep.post`


Note You need to log in before you can comment on or make changes to this bug.