Bug 2318533

Summary: Review Request: rust-crypto_secretbox - Implementation of the XSalsa20Poly1305 and XChaCha20Poly1305 ciphers
Product: [Fedora] Fedora Reporter: Cristian Le <fedora>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, mikel, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/crypto_secretbox
Whiteboard:
Fixed In Version: rust-crypto_secretbox-0.1.1-1.fc42 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-10-15 14:43:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2297310    

Description Cristian Le 2024-10-14 13:46:21 UTC
Spec URL: https://lecris.fedorapeople.org/reviews/rust-crypto_secretbox/rust-crypto_secretbox.spec
SRPM URL: https://lecris.fedorapeople.org/reviews/rust-crypto_secretbox/rust-crypto_secretbox-0.1.1-1.fc42.src.rpm

Description:
Pure Rust implementation of the XSalsa20Poly1305 (a.k.a. NaCl
crypto_secretbox) authenticated encryption cipher as well as the
libsodium variant of XChaCha20Poly1305.


Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=124820481

Comment 1 Cristian Le 2024-10-14 13:47:30 UTC
*** Bug 2259330 has been marked as a duplicate of this bug. ***

Comment 2 Fabio Valentini 2024-10-15 13:59:25 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Cristian Le 2024-10-15 14:14:43 UTC
Thank you for the review, Fabio

Comment 4 Fedora Admin user for bugzilla script actions 2024-10-15 14:14:57 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-crypto_secretbox

Comment 5 Fedora Update System 2024-10-15 14:25:18 UTC
FEDORA-2024-923d1bf2fc (rust-crypto_secretbox-0.1.1-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-923d1bf2fc

Comment 6 Fedora Update System 2024-10-15 14:43:07 UTC
FEDORA-2024-923d1bf2fc (rust-crypto_secretbox-0.1.1-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-10-15 16:52:22 UTC
FEDORA-2024-95eb0a7c9e (rust-crypto_secretbox-0.1.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-95eb0a7c9e

Comment 8 Fedora Update System 2024-10-15 16:52:24 UTC
FEDORA-2024-4a233f0c50 (rust-crypto_secretbox-0.1.1-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4a233f0c50

Comment 9 Fedora Update System 2024-10-16 01:54:42 UTC
FEDORA-2024-4a233f0c50 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4a233f0c50`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4a233f0c50

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-10-16 02:02:52 UTC
FEDORA-2024-95eb0a7c9e has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-95eb0a7c9e`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-95eb0a7c9e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-10-16 02:10:22 UTC
FEDORA-2024-7cd0d80334 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7cd0d80334`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7cd0d80334

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-10-24 01:20:38 UTC
FEDORA-2024-7cd0d80334 (rust-crypto_secretbox-0.1.1-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-10-24 01:28:17 UTC
FEDORA-2024-4a233f0c50 (rust-crypto_secretbox-0.1.1-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2024-10-26 02:57:04 UTC
FEDORA-2024-95eb0a7c9e (rust-crypto_secretbox-0.1.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.