Bug 2318618

Summary:	Review Request: golang-github-xtgo-set - General, type-safe, non-allocating set-operations
Product:	[Fedora] Fedora	Reporter:	Tom.Rix
Component:	Package Review	Assignee:	Mikel Olasagasti Uranga <mikel>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	mikel, package-review
Target Milestone:	---	Flags:	mikel: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-11-05 13:57:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2318425

Description Tom.Rix 2024-10-14 19:48:26 UTC

Spec URL: https://trix.fedorapeople.org/golang-github-xtgo-set.spec
SRPM URL: https://trix.fedorapeople.org/golang-github-xtgo-set-1.0.0-1.fc42.src.rpm

Needed for ollama


Reproducible: Always

Comment 1 Mikel Olasagasti Uranga 2024-10-21 20:20:26 UTC

As with https://bugzilla.redhat.com/show_bug.cgi?id=2318604 can you keep the bootstrapping logic in the spec?

Comment 2 Mikel Olasagasti Uranga 2024-10-30 10:40:29 UTC

Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Comment 3 Fedora Admin user for bugzilla script actions 2024-11-01 00:00:12 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-xtgo-set