Spec URL: https://trix.fedorapeople.org/golang-github-x448-float16.spec SRPM URL: https://trix.fedorapeople.org/golang-github-x448-float16-0.8.4-1.fc42.src.rpm Needed for ollama Reproducible: Always
Spec has been created with go2rpm, but bootstrapping logic has been stripped. Can you run `go2rpm -q github.com/x448/float16` again and keep it? It makes future maintainability easier. Otherwise the spec is fine.
Can you explain why the bootstapping logic is needed ? I did not have to use it.
It was added as part of the go2rpm default template in 1.14 and by default is disabled. The reason it was added is explained here https://gitlab.com/fedora/sigs/go/go2rpm/-/merge_requests/13#note_1965122324 and is used in case it's needed for complex packages. When I mention maintainability I refer that in the future if instead of just bumping the version (manually, using rpmdev-bumpspec, ...) go2rpm is used to update the template, there will be always this change that will need to be reapplied. If you still prefer to remove it, I can review the packages with that preference.
This and the other ollama packages are very simple packages, i removed the bootstrapping logic because to get the package built i did not have to do anything fancy and did not need/use the logic. Not needing something, I removed it to make the spec file simpler.
Is there anything I need to do here ?
> # https://github.com/x448/float16.git This is a manual edit, not from the template. Please, change before pushing. Golang Package Review ============== This package was generated using go2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance Thanks!
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-x448-float16