Bug 2318648

Summary: Review Request: golang-github-hamba-avro2 - A fast Go Avro codec
Product: [Fedora] Fedora Reporter: Tom.Rix
Component: Package ReviewAssignee: Mikel Olasagasti Uranga <mikel>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: mikel, package-review
Target Milestone: ---Flags: mikel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-11-08 12:44:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2318425    

Comment 1 Mikel Olasagasti Uranga 2024-10-21 20:23:02 UTC
Spec name is not correct, please re-run with `go2rpm -q -f https://github.com/hamba/avro github.com/hamba/avro/v2`.

> %build
> for cmd in cmd/* ; do
>  %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
> done

Are the binaries required for ollama? If not, drop %build and %files section and remove the installs from the %install phase.

Comment 2 Mikel Olasagasti Uranga 2024-11-07 12:28:43 UTC
Once the new spec is uploaded with the new name (golang-github-hamba-avro2.spec), change the title of BZ to match it.

Comment 4 Fedora Review Service 2024-11-07 16:25:53 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8227009
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2318648-golang-github-hamba-avro2/fedora-rawhide-x86_64/08227009-golang-github-hamba-avro2/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-hamba-avro2
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Mikel Olasagasti Uranga 2024-11-08 11:25:42 UTC
> %if %{without bootstrap}
> %files
> %license LICENCE
> %doc CODE_OF_CONDUCT.md README.md
> %endif

Remove this section before importing, is not needed for -devel packages.

Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Comment 6 Tom.Rix 2024-11-08 12:44:01 UTC

*** This bug has been marked as a duplicate of bug 2293850 ***