Bug 2319805

Summary: Please branch and build python-libcst for EPEL 10
Product: [Fedora] Fedora Reporter: Xavier Bachelot <xavier>
Component: python-libcstAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: davide, michel, romain.geissler
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-libcst-1.7.0-1.el10_1 python-libcst-1.7.0-1.el10_0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-03-21 01:07:48 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2332630, 2332906, 2332930    
Bug Blocks: 2303880, 2321056    
Attachments:
Description Flags
Missing dependencies from ebranch none

Description Xavier Bachelot 2024-10-18 17:00:47 UTC
Hi,

Could you please branch and build python-libcst for EPEL 10 ?
It is needed to build another package.

Regards,
Xavier

Comment 1 Michel Lind 2024-10-21 17:35:43 UTC
Created attachment 2053011 [details]
Missing dependencies from ebranch

There's a lot of missing dependencies for this, we'll start working on it

Comment 2 Romain Geissler 2024-12-08 14:27:50 UTC
First list of missing dependencies (all rust things):

Error:
 Problem 1: nothing provides requested (crate(chic/default) >= 1.2.2 with crate(chic/default) < 2.0.0~)
 Problem 2: nothing provides requested (crate(itertools/default) >= 0.11.0 with crate(itertools/default) < 0.12.0~)
 Problem 3: nothing provides requested (crate(peg/default) >= 0.8.1 with crate(peg/default) < 0.9.0~)
 Problem 4: nothing provides requested (crate(pyo3/default) >= 0.20.0 with crate(pyo3/default) < 0.21.0~)
 Problem 5: nothing provides requested (crate(pyo3/extension-module) >= 0.20.0 with crate(pyo3/extension-module) < 0.21.0~)

Comment 3 Romain Geissler 2024-12-09 19:26:57 UTC
It seems some of these packages do exists (for example itertools), but in different versions. Does it mean with rust we need to build the same packages, but with multiple versions in parallel ?

Comment 4 Romain Geissler 2024-12-17 22:22:21 UTC
The need for rust-itertools0.11 (https://bugzilla.redhat.com/show_bug.cgi?id=2332630) can be avoided if this pull request is merged: https://src.fedoraproject.org/rpms/python-libcst/pull-request/6 (or if the libcst source are upgraded to the latest upstream version 1.5.1).

Comment 5 Romain Geissler 2024-12-25 17:17:08 UTC
I have updated the above pull request to also upgrade pyo3 to version 0.22. If I locally build all the rust-peg packages and this patched python-libcst, I can successfully boostrap everything on EPEL 10:

[root@03df2990fcb9 python-libcst]# mock --root centos-stream+epel-10-x86_64 --chain ../rust-peg-runtime/rust-peg-runtime-0.8.3-2.el10_0.src.rpm ../rust-peg-macros/rust-peg-macros-0.8.4-1.el10_0.src.rpm ../rust-peg/rust-peg-0.8.4-1.el10_0.src.rpm ../python-libcst/python-libcst-1.4.0-3.el10_0.src.rpm

Comment 6 Romain Geissler 2025-02-06 17:32:00 UTC
With the latest upgrade to version 1.6.0, it now builds fine on EPEL 10 when using the rawhide branch content. See this scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=128917853

Comment 7 Romain Geissler 2025-02-20 23:56:45 UTC
Ping.

I can help building this on EPEL if needed (fas id: romaingeissler1a)

Comment 8 Aoife Moloney 2025-02-26 13:13:30 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 42 development cycle.
Changing version to 42.

Comment 9 Romain Geissler 2025-03-03 19:35:24 UTC
Will you be able to branch and build python-libcst in epel10?
I would be happy to be a co-maintainer if you do not wish
to build it on epel10 (FAS: romaingeissler1a).

Comment 10 Michel Lind 2025-03-19 22:28:44 UTC
If you provide a PR that looks sensible to make this build, I'm happy to add you as a comaintainer


error[E0308]: mismatched types
   --> libcst/src/lib.rs:117:21
    |
117 | /                     format!(
118 | |                         "expected {} {} -> {}",
119 | |                         e.expected, loc.start_pos, loc.end_pos
120 | |                     ),
    | |_____________________^ expected `&str`, found `String`
    |
    = note: this error originates in the macro `format` (in Nightly builds, run with -Z macro-backtrace for more info)

Comment 11 Fedora Update System 2025-03-20 02:18:46 UTC
FEDORA-EPEL-2025-69e90791d6 (python-libcst-1.6.0-2.el10_1) has been submitted as an update to Fedora EPEL 10.1.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-69e90791d6

Comment 12 Fedora Update System 2025-03-20 02:18:47 UTC
FEDORA-EPEL-2025-211d3a71fc (python-libcst-1.6.0-2.el10_0) has been submitted as an update to Fedora EPEL 10.0.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-211d3a71fc

Comment 13 Fedora Update System 2025-03-21 01:07:48 UTC
FEDORA-EPEL-2025-69e90791d6 (python-libcst-1.7.0-1.el10_1) has been pushed to the Fedora EPEL 10.1 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2025-03-21 01:29:00 UTC
FEDORA-EPEL-2025-211d3a71fc (python-libcst-1.7.0-1.el10_0) has been pushed to the Fedora EPEL 10.0 stable repository.
If problem still persists, please make note of it in this bug report.