Bug 2332630 - Please branch and build rust-itertools0.11 in epel10
Summary: Please branch and build rust-itertools0.11 in epel10
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: rust-itertools0.11
Version: epel10
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rust SIG
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 2319805
TreeView+ depends on / blocked
 
Reported: 2024-12-16 18:59 UTC by Romain Geissler
Modified: 2024-12-25 18:20 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-12-25 18:20:36 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Romain Geissler 2024-12-16 18:59:22 UTC
Hi,

Please branch and build rust-itertools0.11 in epel10. It is a dependency of python-libcst.

Cheers,
Romain

Comment 1 Fabio Valentini 2024-12-16 19:03:18 UTC
It would likely be better to bump the itertools dependency from 0.11 to 0.12 in python-libcst before importing it to EPEL 10.

We try to limit the number of "compat" packages (for older versions of Rust crates) that we import into EPEL 10, since they increase maintenance burden in the long term.

Comment 2 Fabio Valentini 2024-12-16 19:03:44 UTC
(leaving open for now until this is addressed)

Comment 3 Romain Geissler 2024-12-17 20:46:33 UTC
If I upgrade libcst to the latest sources (but I can't even submit that as a pull request as I am not a packager yet), the number of missing dependencies when build libcst in EPEL 10 is reduced to:

 Problem 1: nothing provides requested (crate(peg/default) >= 0.8.4 with crate(peg/default) < 0.9.0~)
 Problem 2: nothing provides requested (crate(pyo3/default) >= 0.20.0 with crate(pyo3/default) < 0.21.0~)
 Problem 3: nothing provides requested (crate(pyo3/extension-module) >= 0.20.0 with crate(pyo3/extension-module) < 0.21.0~)

peg 0.8 is already the "latest" version, so here just asking for an EPEL 10 branching should be enough.

For pyo3, it seems the latest upstream version is 0.23. However I did find this dependabot pull request upstream https://github.com/Instagram/LibCST/pull/1259 where the CI lots of failure, so I assume libcst is not ready for the upgrade just yet. So would it be ok to branch just rust-pyo30.20 for EPEL 10 ?

Comment 4 Romain Geissler 2024-12-17 20:49:13 UTC
Note: there is also this pull request (still not merged for now) to upgrade to pyo3 0.22: https://github.com/Instagram/LibCST/pull/1180

Comment 5 Fabio Valentini 2024-12-17 21:12:12 UTC
I'm slightly confused what you're trying to do here - what I suggested in Comment 1 was to patch the *current* version of python-libcst to build with itertools 0.12 instead of 0.12.

The fact that it pulls in outdated versions of pyo3 is a different problem.

Comment 6 Romain Geissler 2024-12-17 22:16:51 UTC
Ok, I would naively thought it was more logical to upgrade libcst sources (which indirectly also upgrades the itertools dependency version) than backporting in an old libcst an upstream upstream upgrade of itertools. Both fix the issue though, and I have just submitted this which works both in rawhide and EPEL 10 (EPEL still lacks the above mentionned rust dependencies):

https://src.fedoraproject.org/rpms/python-libcst/pull-request/6

So if this pull request is merged, this ticket can be closed as "WONT FIX".

Comment 7 Fabio Valentini 2024-12-25 18:20:36 UTC
Thanks, the PR looks good to me. Knowing the maintainers of python-libcst (they are both also Rust SIG members), I assume the PR will get merged.


Note You need to log in before you can comment on or make changes to this bug.