Bug 2321312

Summary:	Review Request: rust-serial - Rust library for accessing serial ports
Product:	[Fedora] Fedora	Reporter:	solomoncyj
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	41	CC:	decathorpe, jjelen, package-review, pemensik
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
URL:	https://crates.io/crates/serial
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-12-06 02:51:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2318048
Bug Blocks:	2318055

Description solomoncyj 2024-10-23 16:46:59 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-rawhide-x86_64/08159642-rust-serial/rust-serial.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-rawhide-x86_64/08159642-rust-serial/rust-serial-0.4.0-1.fc42.src.rpm
Description: Rust library for accessing serial ports
Fedora Account System Username: solomoncyj
Reproducible: Always


Reproducible: Always

Comment 1 Fedora Review Service 2024-10-23 16:48:45 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8169859
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2321312-rust-serial/fedora-rawhide-x86_64/08169859-rust-serial/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Jakub Jelen 2024-11-11 14:58:14 UTC

FTR, this one fails to build because of dependency on serial-core and serial-unix

DEBUG util.py:459:  Failed to resolve the transaction:
DEBUG util.py:459:  Package "cargo-rpm-macros-26.3-3.fc42.noarch" is already installed.
DEBUG util.py:459:  No match for argument: crate(serial-core/default) = 0.4.0
DEBUG util.py:459:  No match for argument: crate(serial-unix/default) = 0.4.0

Comment 3 Petr Menšík 2024-11-15 20:18:47 UTC

Sure, these should be packaged as separate components and therefore should have separate package reviews, blocking this bug.

- https://crates.io/crates/serial-unix/0.4.0
- https://crates.io/crates/serial-core/0.4.0

Comment 4 solomoncyj 2024-11-16 00:23:26 UTC

sorry, adding bugs to the depens on: tracker

Comment 5 Fabio Valentini 2024-12-04 17:22:24 UTC

Note that the "serial" crate (and its subprojects, by association) are now officially documented as unmaintained:
https://rustsec.org/advisories/RUSTSEC-2017-0008.html

I would recommend to ask upstream to switch to a different library instead of packaging an obsolete library.