Bug 2323517

Summary: Review Request: rust-keyvalues-parser - Parser/renderer for vdf text
Product: [Fedora] Fedora Reporter: Jonathan Steffan <jonathansteffan>
Component: Package ReviewAssignee: Davide Cavalca <davide>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: davide, package-review
Target Milestone: ---Flags: davide: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/keyvalues-parser
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-11-05 04:38:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2292541, 2323518    

Description Jonathan Steffan 2024-11-03 16:08:02 UTC
Spec URL: https://jsteffan.fedorapeople.org/envision/rust-keyvalues-parser.spec
SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-keyvalues-parser-0.2.0-1.fc40/rust-keyvalues-parser-0.2.0-1.fc42.src.rpm
Description: Parser/renderer for vdf text
Fedora Account System Username: jsteffan

Comment 1 Jonathan Steffan 2024-11-03 16:10:15 UTC
[scripts.prep]
post = [
	"#Copy LICENSE files",
	"cp -pav %{SOURCE100} %{SOURCE101} .",
]

Comment 2 Fedora Review Service 2024-11-03 16:14:29 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8205798
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2323517-rust-keyvalues-parser/fedora-rawhide-x86_64/08205798-rust-keyvalues-parser/fedora-review/review.txt

Found issues:

- Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/rust-keyvalues-parser/diff.txt
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2024-11-04 04:23:48 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 4 Fedora Admin user for bugzilla script actions 2024-11-05 04:21:03 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-keyvalues-parser

Comment 5 Fedora Update System 2024-11-05 04:35:53 UTC
FEDORA-2024-12ec975ea8 (rust-keyvalues-parser-0.2.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-12ec975ea8

Comment 6 Fedora Update System 2024-11-05 04:38:37 UTC
FEDORA-2024-12ec975ea8 (rust-keyvalues-parser-0.2.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.