Bug 2323518 - Review Request: rust-keyvalues-serde - (De)serialize VDF text with serde
Summary: Review Request: rust-keyvalues-serde - (De)serialize VDF text with serde
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/keyvalues-serde
Whiteboard:
Depends On: 2323517
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-11-03 16:09 UTC by Jonathan Steffan
Modified: 2024-11-05 05:11 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-11-05 05:11:37 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Jonathan Steffan 2024-11-03 16:09:15 UTC
Spec URL: https://jsteffan.fedorapeople.org/envision/rust-keyvalues-serde.spec
SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-keyvalues-serde-0.2.1-1.fc40/rust-keyvalues-serde-0.2.1-1.fc42.src.rpm
Description: (De)serialize VDF text with serde
Fedora Account System Username: jsteffan

Comment 1 Jonathan Steffan 2024-11-03 16:09:57 UTC
[scripts.prep]
post = [
	"#Copy LICENSE files",
	"cp -pav %{SOURCE100} %{SOURCE101} .",
]

Comment 2 Fedora Review Service 2024-11-03 16:11:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8205816
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2323518-rust-keyvalues-serde/fedora-rawhide-x86_64/08205816-rust-keyvalues-serde/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2024-11-04 04:24:24 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 4 Fedora Admin user for bugzilla script actions 2024-11-05 04:21:49 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-keyvalues-serde

Comment 5 Fedora Update System 2024-11-05 05:08:59 UTC
FEDORA-2024-2ae26ec668 (rust-keyvalues-serde-0.2.1-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-2ae26ec668

Comment 6 Fedora Update System 2024-11-05 05:11:37 UTC
FEDORA-2024-2ae26ec668 (rust-keyvalues-serde-0.2.1-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.