Bug 2323713

Summary: Review Request: modpoll - A command line tool for Modbus and MQTT
Product: [Fedora] Fedora Reporter: Peter Robinson <pbrobinson>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: NEW --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: benson_muite, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/gavinying/modpoll
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1269538    
Attachments:
Description Flags
The .spec file difference from Copr build 9769597 to 9775466 none

Description Peter Robinson 2024-11-04 19:35:03 UTC
SPEC: https://pbrobinson.fedorapeople.org/modpoll.spec
SRPM: https://pbrobinson.fedorapeople.org/modpoll-1.3.3-1.fc41.src.rpm

Description:
A command line tool for Modbus and MQTT

FAS: pbrobinson

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=125512021

Comment 1 Fedora Review Service 2024-11-04 19:37:05 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8209906
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2323713-modpoll/fedora-rawhide-x86_64/08209906-modpoll/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Package Review 2025-11-05 00:45:33 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 3 Peter Robinson 2025-11-05 09:46:22 UTC
yes

Comment 4 Benson Muite 2025-11-05 13:55:20 UTC
[fedora-review-service-build]

Comment 5 Fedora Review Service 2025-11-05 13:57:01 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9769597
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2323713-modpoll/fedora-rawhide-x86_64/09769597-modpoll/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Benson Muite 2025-11-05 14:01:41 UTC
Can you update to the latest release 1.5.1?

Pymodbus in Fedora is 3.9.2:
https://src.fedoraproject.org/rpms/pymodbus

The Package seems to need 3.6.9:
https://github.com/gavinying/modpoll/blob/master/pyproject.toml#L13

Maybe it would work if the dependency restriction is relaxed?

Comment 7 Peter Robinson 2025-11-06 09:43:20 UTC
Yes, when I submitted this is was the right version, I updated all that in my local/copr build but given no one had picked this up in a year I'd not updated it.

SPEC: https://pbrobinson.fedorapeople.org/modpoll.spec
SRPM: https://pbrobinson.fedorapeople.org/modpoll-1.5.1-1.fc43.src.rpm

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=138771786

Comment 8 Fedora Review Service 2025-11-07 04:19:22 UTC
Created attachment 2113148 [details]
The .spec file difference from Copr build 9769597 to 9775466

Comment 9 Fedora Review Service 2025-11-07 04:19:24 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9775466
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2323713-modpoll/fedora-rawhide-x86_64/09775466-modpoll/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.