SPEC: https://pbrobinson.fedorapeople.org/modpoll.spec SRPM: https://pbrobinson.fedorapeople.org/modpoll-1.3.3-1.fc41.src.rpm Description: A command line tool for Modbus and MQTT FAS: pbrobinson koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=125512021
Copr build: https://copr.fedorainfracloud.org/coprs/build/8209906 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2323713-modpoll/fedora-rawhide-x86_64/08209906-modpoll/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
yes
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9769597 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2323713-modpoll/fedora-rawhide-x86_64/09769597-modpoll/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Can you update to the latest release 1.5.1? Pymodbus in Fedora is 3.9.2: https://src.fedoraproject.org/rpms/pymodbus The Package seems to need 3.6.9: https://github.com/gavinying/modpoll/blob/master/pyproject.toml#L13 Maybe it would work if the dependency restriction is relaxed?
Yes, when I submitted this is was the right version, I updated all that in my local/copr build but given no one had picked this up in a year I'd not updated it. SPEC: https://pbrobinson.fedorapeople.org/modpoll.spec SRPM: https://pbrobinson.fedorapeople.org/modpoll-1.5.1-1.fc43.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=138771786
Created attachment 2113148 [details] The .spec file difference from Copr build 9769597 to 9775466
Copr build: https://copr.fedorainfracloud.org/coprs/build/9775466 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2323713-modpoll/fedora-rawhide-x86_64/09775466-modpoll/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The pymodbus version is bumped for new upstream 1.6.0 SPEC: https://pbrobinson.fedorapeople.org/modpoll.spec SRPM: https://pbrobinson.fedorapeople.org/modpoll-1.6.0-1.fc43.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=139757915
Created attachment 2117790 [details] The .spec file difference from Copr build 9775466 to 9883282
Copr build: https://copr.fedorainfracloud.org/coprs/build/9883282 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2323713-modpoll/fedora-rawhide-x86_64/09883282-modpoll/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Fixed the missing v in the source URL too.
Hi, I will take this one, review to follow. Regards Phil
Hi, Issue I see is 'tests' in the package but no '%check' section with test triggering. With the above resolved I believe we can move forward. Regards Phil
> Issue I see is 'tests' in the package but no '%check' section with test > triggering. The tests need external connectivity so they fail in the constrained build environment so I never enabled them, also given it's modbus, a physical HW, I'm not sure of the value of running the tests. I can add them to the spec wrapped in an if tests for completeness if you insist.
Added tests with a conditional with them disabled. SPEC: https://pbrobinson.fedorapeople.org/modpoll.spec SRPM: https://pbrobinson.fedorapeople.org/modpoll-1.6.0-1.fc43.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=143353020
Created attachment 2133374 [details] The .spec file difference from Copr build 9883282 to 10225222
Copr build: https://copr.fedorainfracloud.org/coprs/build/10225222 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2323713-modpoll/fedora-rawhide-x86_64/10225222-modpoll/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Peter Robinson from comment #16) > > Issue I see is 'tests' in the package but no '%check' section with test > > triggering. > > The tests need external connectivity so they fail in the constrained build > environment so I never enabled them, also given it's modbus, a physical HW, > I'm not sure of the value of running the tests. I can add them to the spec > wrapped in an if tests for completeness if you insist. No need to add the tests after looking at them. One thing to fix is 'spectool -g -R <specfile>'. philwyett @ ks-kenobi ~/Development/rpm_build >> spectool -g -R SPECS/modpoll.spec Downloading: https://github.com/gavinying/modpoll/archive/1.6.0.tar.gz#/modpoll-1.6.0.tar.gz Download failed: 404 Client Error: Not Found for url: https://codeload.github.com/gavinying/modpoll/tar.gz/1.6.0#/modpoll-1.6.0.tar.gz Change 'Source0' to line below. Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz Regards Phil
Can you do the full review and just leave me a single list of things that need fixing?
(In reply to Peter Robinson from comment #21) > Can you do the full review and just leave me a single list of things that > need fixing? Comment 20 is the last thing that needs to be fixed. I try to give full one shot reviews, but other tasks and my disability sometimes do not allow it. I am trying to work from the oldest review requests to the newest (reviews that I have interest and experience in), a task I do not see anyone else taking on. Do this last thing and I will mark as '+' and allow you to request repo and import the latest srpm. Regards Phil
Updated, thanks SPEC: https://pbrobinson.fedorapeople.org/modpoll.spec SRPM: https://pbrobinson.fedorapeople.org/modpoll-1.6.0-1.fc43.src.rpm
Created attachment 2133396 [details] The .spec file difference from Copr build 10225222 to 10225616
Copr build: https://copr.fedorainfracloud.org/coprs/build/10225616 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2323713-modpoll/fedora-rawhide-x86_64/10225616-modpoll/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi, Looks good to me. Apologies for the emotional dump, but I do what I can when I can. Marking as '+'. As seasoned packager you will now be able to: 1. Request reo. 2. Import latestt srpm. etc. :-) Regards Phil
The Pagure repository was created at https://src.fedoraproject.org/rpms/modpoll
Thanks! And no problems, as they once said on the internet no one knows you're a dog :)
FEDORA-2026-ad97dca847 (modpoll-1.6.0-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-ad97dca847
FEDORA-2026-ad97dca847 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-ad97dca847 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-ad97dca847 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-ad97dca847 (modpoll-1.6.0-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.