Bug 2324442

Summary:	Review Request: showtime - Modern video player built using GTK4
Product:	[Fedora] Fedora	Reporter:	Steve Cossette <farchord>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, mcatanza, ngompa13, package-review
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	---	Flags:	ngompa13: fedora-review+
Hardware:	Unspecified
OS:	Unspecified
URL:	https://apps.gnome.org/Showtime/
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-11-13 14:36:10 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Steve Cossette 2024-11-07 19:10:28 UTC

Spec URL: https://farchord.fedorapeople.org/reviews/showtime/showtime.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/showtime/showtime-48.0~20241104.080500.5579430-1.fc41.src.rpm

Description:
Play your favorite movies and video files without hassle. Showtime
features simple playback controls that fade out of your way when
you're watching, fullscreen, adjustable playback speed, multiple
language and subtitle tracks, and screenshots — everything you
need for a straightforward viewing experience.

Fedora Account System Username: farchord

Comment 1 Fedora Review Service 2024-11-07 19:17:30 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8227370
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2324442-showtime/fedora-rawhide-x86_64/08227370-showtime/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2024-11-07 19:54:31 UTC

Taking this review.

Comment 3 Neal Gompa 2024-11-13 13:34:54 UTC

Review notes:

* Package follows packaging guidelines
* Package builds and installs
* Package licensing is correct and license file is installed
* No serious issues from rpmlint

Note: Please replace usage of "$RPM_BUILD_ROOT" with "%{buildroot}" before importing.

PACKAGE APPROVED.

Recommended post-import tasks:

- set up package on release-monitoring.org:

- add @gnome-sig with "admin" access as package co-maintainer

- set bugzilla assignee overrides to @gnome-sig

- track package in koschei for all built branches

Comment 4 Steve Cossette 2024-11-13 13:45:40 UTC

Thank you for the review, Neal

Comment 5 Fedora Admin user for bugzilla script actions 2024-11-13 13:45:59 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/showtime

Comment 6 Fabio Valentini 2024-12-18 21:06:09 UTC

Looks like one issue was missed - the package should probably be "BuildArch: noarch" (it's Pure-Python), and not set %debug_package %nil. Not sure if that can be switched safely after the fact, though.

Comment 7 Michael Catanzaro 2024-12-18 21:10:15 UTC

Let's try to fix it and see what breaks.

We might need to use Obsoletes, but that's probably OK.