Spec URL: https://farchord.fedorapeople.org/reviews/showtime/showtime.spec SRPM URL: https://farchord.fedorapeople.org/reviews/showtime/showtime-48.0~20241104.080500.5579430-1.fc41.src.rpm Description: Play your favorite movies and video files without hassle. Showtime features simple playback controls that fade out of your way when you're watching, fullscreen, adjustable playback speed, multiple language and subtitle tracks, and screenshots — everything you need for a straightforward viewing experience. Fedora Account System Username: farchord
Copr build: https://copr.fedorainfracloud.org/coprs/build/8227370 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2324442-showtime/fedora-rawhide-x86_64/08227370-showtime/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this review.
Review notes: * Package follows packaging guidelines * Package builds and installs * Package licensing is correct and license file is installed * No serious issues from rpmlint Note: Please replace usage of "$RPM_BUILD_ROOT" with "%{buildroot}" before importing. PACKAGE APPROVED. Recommended post-import tasks: - set up package on release-monitoring.org: - add @gnome-sig with "admin" access as package co-maintainer - set bugzilla assignee overrides to @gnome-sig - track package in koschei for all built branches
Thank you for the review, Neal
The Pagure repository was created at https://src.fedoraproject.org/rpms/showtime
Looks like one issue was missed - the package should probably be "BuildArch: noarch" (it's Pure-Python), and not set %debug_package %nil. Not sure if that can be switched safely after the fact, though.
Let's try to fix it and see what breaks. We might need to use Obsoletes, but that's probably OK.