Bug 2324991
| Summary: | Review Request: gopls - gopls, the Go language server | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Elliott Sales de Andrade <quantum.analyst> |
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | mikel, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | mikel:
fedora-review+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://github.com/golang/tools | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-11-15 13:56:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Elliott Sales de Andrade
2024-11-10 10:42:25 UTC
This is split out of golang-x-tools so that it can be built independently, and using the correct version. Note that that previously produced golang-x-tools-gopls, and I'm not adverse to using that name, but it would require starting this package with an Epoch. Copr build: https://copr.fedorainfracloud.org/coprs/build/8238868 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2324991-gopls/fedora-rawhide-x86_64/08238868-gopls/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Golang Package Review
==============
This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [x] The package's binaries don't conflict with binaries already in the distribution. <-- does, but it's part of the fix
- [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance
Thanks!
Thank you for the review, Mikel The Pagure repository was created at https://src.fedoraproject.org/rpms/gopls FEDORA-2024-5c38d3ef86 (gopls-0.16.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5c38d3ef86 FEDORA-2024-5c38d3ef86 (gopls-0.16.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |