Spec URL: https://qulogic.fedorapeople.org/reviews/gopls/gopls.spec SRPM URL: https://qulogic.fedorapeople.org/reviews/gopls/gopls-0.16.2-2.fc42.src.rpm Description: gopls (pronounced "Go please") is the official Go language server developed by the Go team. It provides IDE features to any LSP-compatible editor. You should not need to interact with gopls directly--it will be automatically integrated into your editor. The specific features and settings vary slightly by editor, so we recommend that you proceed to the documentation for your editor.
This is split out of golang-x-tools so that it can be built independently, and using the correct version. Note that that previously produced golang-x-tools-gopls, and I'm not adverse to using that name, but it would require starting this package with an Epoch.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8238868 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2324991-gopls/fedora-rawhide-x86_64/08238868-gopls/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Golang Package Review ============== This package was generated using go2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [x] The package's binaries don't conflict with binaries already in the distribution. <-- does, but it's part of the fix - [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance Thanks!
Thank you for the review, Mikel
The Pagure repository was created at https://src.fedoraproject.org/rpms/gopls
FEDORA-2024-5c38d3ef86 (gopls-0.16.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5c38d3ef86
FEDORA-2024-5c38d3ef86 (gopls-0.16.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.