Bug 2327780

Spec URL: https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fedora-rawhide-x86_64/08335240-rust-az-snp-vtpm/rust-az-snp-vtpm.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fedora-rawhide-x86_64/08335240-rust-az-snp-vtpm/rust-az-snp-vtpm-0.7.1-1.fc42.src.rpm

Spec file created with: rust2rpm az-snp-vtpm 0.7.1 -I

rust2rpm.toml:
[package]
extra-sources = [
    { "number" = 1, "file" = "LICENSE", "comments" = [ "SOURCES were copied from copied from github:",
	"http://github.com/kinvolk/azure-cvm-tooling/" ] },
    { "number" = 2, "file" = "hcl-report-snp.bin", "comments" = [ "required by tests" ] },
    { "number" = 3, "file" = "certs.pem", "comments" = [ "required by tests" ] },
]
cargo-install-lib = true
cargo-install-bin = false

[scripts]
prep.pre = [ "cp -f %{SOURCE1} ." ]
check.pre = [ "mkdir -p ../test", "cp -f %{SOURCE2} %{SOURCE3} ../test" ]
check.post = [ "rm -rf ../test" ]

[features]
hide = ["integration_test"]

# add to %files:
# %license %{crate_instdir}/LICENSE

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8341312
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327780-rust-az-snp-vtpm/fedora-rawhide-x86_64/08341312-rust-az-snp-vtpm/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

scratch build fails on non-x86_64, but I confirmed adding `supported-arches = ["x86_64"]` to rust2rpm.toml fixes it

rust2rpm.toml comments can also point to your PR fixing those SOURCES issues: https://github.com/kinvolk/azure-cvm-tooling/pull/64

rust2rpm also prings a warning: ARNING: Extra source 'LICENSE' might conflict with other files in the future. Using source numbers >= 2 is recommended.

So maybe number your sources 11,12,13 or similar

Cole, thank you for the review.

SPEC URL: https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fedora-rawhide-x86_64/08660986-rust-az-snp-vtpm/rust-az-snp-vtpm.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fedora-rawhide-x86_64/08660986-rust-az-snp-vtpm/rust-az-snp-vtpm-0.7.1-1.fc43.src.rpm


rust2rpm.toml:
[package]
extra-sources = [
    { "number" = 11, "file" = "https://raw.githubusercontent.com/kinvolk/azure-cvm-tooling/2bef60b88db7554935177ec63dd169190a39eab7/LICENSE", "comments" = [ "The crate does not contain LICENSE; Get it from upstream git repo", "http://github.com/kinvolk/azure-cvm-tooling/", "A patch was sent upstream:", "https://github.com/kinvolk/azure-cvm-tooling/pull/64" ] },
    { "number" = 12, "file" = "https://raw.githubusercontent.com/kinvolk/azure-cvm-tooling/2bef60b88db7554935177ec63dd169190a39eab7/az-cvm-vtpm/test/hcl-report-snp.bin", "comments" = [ "required by tests" ] },
    { "number" = 13, "file" = "https://raw.githubusercontent.com/kinvolk/azure-cvm-tooling/2bef60b88db7554935177ec63dd169190a39eab7/az-cvm-vtpm/test/certs.pem", "comments" = [ "required by tests" ] },
]
cargo-install-lib = true
cargo-install-bin = false
supported-arches = [ "x86_64"]

[scripts]
prep.pre = [ "cp -f %{SOURCE11} ." ]
check.pre = [ "mkdir -p ../test", "cp -f %{SOURCE12} %{SOURCE13} ../test" ]
check.post = [ "rm -rf ../test" ]

[features]
hide = ["integration_test"]

# add to %files:
# %license %{crate_instdir}/LICENSE

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8661125
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327780-rust-az-snp-vtpm/fedora-rawhide-x86_64/08661125-rust-az-snp-vtpm/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

LGTM now

+ content matches rust2rpm.toml output (with the mentioned %license tweak)
+ builds on rawhide
+ installs on rawhide
+ content looks fine

setting fedora-review+

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-az-snp-vtpm

FEDORA-2025-4e40b72267 (rust-az-snp-vtpm-0.7.1-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-4e40b72267

FEDORA-2025-4e40b72267 (rust-az-snp-vtpm-0.7.1-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.