Bug 2327778 - Review Request: rust-az-cvm-vtpm - Attestation for Azure Confidential Virtual Machines
Summary: Review Request: rust-az-cvm-vtpm - Attestation for Azure Confidential Virtual...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/az-cvm-vtpm
Whiteboard:
Depends On: 2326979 2330861
Blocks: 2327780 2327782
TreeView+ depends on / blocked
 
Reported: 2024-11-21 11:25 UTC by Uri Lublin
Modified: 2025-01-29 15:26 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-01-29 15:26:22 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 8341290 to 8341736 (617 bytes, patch)
2024-12-04 19:30 UTC, Fedora Review Service
no flags Details | Diff

Description Uri Lublin 2024-11-21 11:25:25 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fedora-rawhide-x86_64/08272762-rust-az-cvm-vtpm/rust-az-cvm-vtpm.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fedora-rawhide-x86_64/08272762-rust-az-cvm-vtpm/rust-az-cvm-vtpm-0.7.0-1.fc42.src.rpm
Description: Enables getting confidential computing information from the
hardware/firmware, when running on a confidential VM (CVM) on Azure.
The confidential computing "evidence" is used for attestation.

This is a first of 3 packages, and is a common one.
The other 2 are specific for the CPU Vendor:
 - rust-az-snp-vtpm # AMD SEV-SNP
 - rust-az-tdx-vtpm # Intel TDX

Git repository for all 3 packages: https://github.com/kinvolk/azure-cvm-tooling/

Fedora Account System Username: uril

Comment 1 Uri Lublin 2024-11-29 07:58:54 UTC
rust2rpm.toml:
[package]
extra-sources = [
    { "number" = 1, "file" = "LICENSE", "comments" = [ "LICENSE is copied from azure-cvm-tooling github repo"] },
]
 
[scripts]
prep.pre = [ "cp -f %{SOURCE1} ." ]

# add to %files:
# %license %{crate_instdir}/LICENSE

Comment 3 Fabio Valentini 2024-12-04 15:33:07 UTC
Please use a URL for Source1 to make it clear that you're not adding some random "LICENSE" file, but the actual one from upstream.
If this has not yet happened, please file a ticket with upstream to include the license texts in all published crates.

Comment 4 Fedora Review Service 2024-12-04 15:38:59 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8341290
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327778-rust-az-cvm-vtpm/fedora-rawhide-x86_64/08341290-rust-az-cvm-vtpm/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Uri Lublin 2024-12-04 19:22:15 UTC
Thanks Fabio

(In reply to Fabio Valentini from comment #3)
> Please use a URL for Source1 to make it clear that you're not adding some
> random "LICENSE" file, but the actual one from upstream.

Added a URL for Source1.
It points to the commit of the crate, in case it changes in the main branch.

> If this has not yet happened, please file a ticket with upstream to include
> the license texts in all published crates.

I've sent a patch

Comment 7 Fedora Review Service 2024-12-04 19:30:38 UTC
Created attachment 2061226 [details]
The .spec file difference from Copr build 8341290 to 8341736

Comment 8 Fedora Review Service 2024-12-04 19:30:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8341736
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327778-rust-az-cvm-vtpm/fedora-rawhide-x86_64/08341736-rust-az-cvm-vtpm/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Fabio Valentini 2025-01-26 21:16:31 UTC
Looks good to me now, thank you!

Can you add a link to the PR you filed as a comment to the additional LICENSE Source file?
https://github.com/kinvolk/azure-cvm-tooling/pull/64

===

Package was generated with rust2rpm, simplifying the review.

✅❌❓🫤

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
🫤 license file is included with %license in %files (temporarily manually included from upstream git)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 10 Uri Lublin 2025-01-27 11:52:09 UTC
Thank you Fabio.
I'll add a link to the PR in the comments above Source1

Comment 11 Fedora Admin user for bugzilla script actions 2025-01-28 15:25:58 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-az-cvm-vtpm

Comment 14 Fedora Update System 2025-01-29 15:22:57 UTC
FEDORA-2025-7ba288f15e (rust-az-cvm-vtpm-0.7.1-3.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-7ba288f15e

Comment 15 Fedora Update System 2025-01-29 15:26:22 UTC
FEDORA-2025-7ba288f15e (rust-az-cvm-vtpm-0.7.1-3.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.