Bug 2329181 (rust-sspi)
| Summary: | Review Request: rust-sspi - Rust implementation of the Security Support Provider Interface | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marc-Andre Lureau <marcandre.lureau> | ||||||
| Component: | Package Review | Assignee: | Cole Robinson <crobinso> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | crobinso, danfrantes, decathorpe, package-review | ||||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||
| Target Release: | --- | Flags: | crobinso:
fedora-review+
|
||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://crates.io/crates/sspi | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2025-03-04 18:59:52 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 1878260, 2327679, 2336864, 2343680, 2346893, 2346938 | ||||||||
| Bug Blocks: | 2329180 | ||||||||
| Attachments: |
|
||||||||
|
Description
Marc-Andre Lureau
2024-11-27 17:51:15 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8319583 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329181-rust-sspi/fedora-rawhide-x86_64/08319583-rust-sspi/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/8330105 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329181-rust-sspi/fedora-rawhide-x86_64/08330105-rust-sspi/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I'll review this, but please update builds for latest 0.15.1 release Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-sspi/rust-sspi.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08674717/rust-sspi-0.15.1-1.src.rpm Description: Rust implementation of the Security Support Provider Interface Fedora Account System Username: elmarco Copr build: https://copr.fedorainfracloud.org/coprs/build/8675805 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329181-rust-sspi/fedora-rawhide-x86_64/08675805-rust-sspi/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. rawhide build is failing: DEBUG util.py:459: Problem: nothing provides requested (crate(picky-krb/default) >= 0.9.0 with crate(picky-krb/default) < 0.10.0~) added missing dep Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-sspi/rust-sspi.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08674717/rust-sspi-0.15.1-1.src.rpm Description: Rust implementation of the Security Support Provider Interface Fedora Account System Username: elmarco copr build succeeded (on x86 atm): https://copr.fedorainfracloud.org/coprs/elmarco/qemu-rdp/build/8702701/ Copr build: https://copr.fedorainfracloud.org/coprs/build/8702787 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329181-rust-sspi/fedora-rawhide-x86_64/08702787-rust-sspi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. This still has install issues: Problem 1: conflicting requests - nothing provides (crate(rustls/aws-lc-rs) >= 0.23.0 with crate(rustls/aws-lc-rs) < 0.24.0~) needed by rust-sspi+aws-lc-rs-devel-0.15.1-1.fc43.noarch from @commandline Problem 2: conflicting requests - nothing provides (crate(winscard/default) >= 0.2.0 with crate(winscard/default) < 0.3.0~) needed by rust-sspi+scard-devel-0.15.1-1.fc43.noarch from @commandline You can try to add to command line: --skip-broken to skip uninstallable packages The generated package list looks weird too: # ls rust-sspi-0.15.1-1.fc43.src.rpm rust-sspi+aws-lc-rs-devel-0.15.1-1.fc43.noarch.rpm rust-sspi+default-devel-0.15.1-1.fc43.noarch.rpm rust-sspi-devel-0.15.1-1.fc43.noarch.rpm rust-sspi+dns_resolver-devel-0.15.1-1.fc43.noarch.rpm rust-sspi+__install-crypto-provider-devel-0.15.1-1.fc43.noarch.rpm rust-sspi+network_client-devel-0.15.1-1.fc43.noarch.rpm rust-sspi+ring-devel-0.15.1-1.fc43.noarch.rpm rust-sspi+__rustls-used-devel-0.15.1-1.fc43.noarch.rpm rust-sspi+scard-devel-0.15.1-1.fc43.noarch.rpm rust-sspi+__test-data-devel-0.15.1-1.fc43.noarch.rpm rust-sspi+tsssp-devel-0.15.1-1.fc43.noarch.rpm Notice the double underscore packages, that seems wrong but I didn't dig into it Package could also use rust2rpm.toml with a comment for the manual metadata change Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-sspi/rust-sspi.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08704880/rust-sspi-0.15.1-1.src.rpm Description: Rust implementation of the Security Support Provider Interface Fedora Account System Username: elmarco thanks Created attachment 2078015 [details]
The .spec file difference from Copr build 8702787 to 8704912
Copr build: https://copr.fedorainfracloud.org/coprs/build/8704912 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329181-rust-sspi/fedora-rawhide-x86_64/08704912-rust-sspi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Something still ain't right, installing all subpackages is failing on rawhide. Please confirm install is working before posting new builds
You can use a section like this in rust2rpm.toml to avoid the $EDITOR drop in
[package]
extra-patches = [
{ number = 10, file = "sspi-fix-metadata.diff", comments = ["default to the ring crypto backend"] }
]
> [package]
> extra-patches = [
> { number = 10, file = "sspi-fix-metadata.diff", comments = ["default to the ring crypto backend"] }
> ]
For the record, extra-patches is for patches *other* than those touching Cargo.toml.
To persist those changes, use
"""
[package]
cargo-toml-patch-comments = ["default to the ring crypto backend"]
"""
in conjunction with "rust2rpm --reuse-patch", instead.
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-sspi/rust-sspi.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08723076/rust-sspi-0.15.2-1.src.rpm Description: Rust implementation of the Security Support Provider Interface Fedora Account System Username: elmarco Created attachment 2078860 [details]
The .spec file difference from Copr build 8704912 to 8723100
Copr build: https://copr.fedorainfracloud.org/coprs/build/8723100 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329181-rust-sspi/fedora-rawhide-x86_64/08723100-rust-sspi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. (In reply to Fabio Valentini from comment #16) > > [package] > > extra-patches = [ > > { number = 10, file = "sspi-fix-metadata.diff", comments = ["default to the ring crypto backend"] } > > ] > > For the record, extra-patches is for patches *other* than those touching > Cargo.toml. Ok noted, thanks. Does it trigger different behavior? * spec content matches rust2rpm.toml output (and it's correctly using --reuse-patch like suggested) * builds on rawhide * installs on rawhide * content looks fine setting fedora-review+ The underscore in crate names still seem weird but that's just how the upstream package is arranged apparently... The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sspi FEDORA-2025-b6423389be (rust-sspi-0.15.2-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-b6423389be FEDORA-2025-b6423389be (rust-sspi-0.15.2-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. |