Bug 2330124
| Summary: | Review Request: rust-oid-registry - Object Identifier (OID) database | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tyler Fanelli <tfanelli> | ||||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | crobinso, davide, decathorpe, package-review | ||||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://crates.io/crates/oid-registry | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2024-12-12 06:04:47 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 2312637 | ||||||||
| Bug Blocks: | 2313237 | ||||||||
| Attachments: |
|
||||||||
|
Description
Tyler Fanelli
2024-12-03 06:44:51 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8335988 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330124-rust-oid-registry/fedora-rawhide-x86_64/08335988-rust-oid-registry/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://raw.githubusercontent.com/tylerfanelli/f42-rust-oid-registry-candidate/refs/heads/main/rust-oid-registry.spec SRPM URL: https://github.com/tylerfanelli/f42-rust-oid-registry-candidate/raw/refs/heads/main/rust-oid-registry-0.7.0-1.fc42.src.rpm Description: Rust Object Identifier (OID) database Fedora Account System Username: tfanelli Copr build: https://copr.fedorainfracloud.org/coprs/build/8371533 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330124-rust-oid-registry/fedora-rawhide-x86_64/08371533-rust-oid-registry/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://raw.githubusercontent.com/tylerfanelli/f42-rust-oid-registry-candidate/refs/heads/main/rust-oid-registry.spec SRPM URL: https://github.com/tylerfanelli/f42-rust-oid-registry-candidate/raw/refs/heads/main/rust-oid-registry-0.7.0-1.fc42.src.rpm Description: Rust Object Identifier (OID) database Fedora Account System Username: tfanelli Copr build: https://copr.fedorainfracloud.org/coprs/build/8371563 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330124-rust-oid-registry/fedora-rawhide-x86_64/08371563-rust-oid-registry/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://raw.githubusercontent.com/tylerfanelli/f42-rust-oid-registry-candidate/refs/heads/main/rust-oid-registry.spec SRPM URL: https://github.com/tylerfanelli/f42-rust-oid-registry-candidate/raw/refs/heads/main/rust-oid-registry-0.7.1-1.fc42.src.rpm Description: Rust Object Identifier (OID) database Fedora Account System Username: tfanelli Created attachment 2061814 [details]
The .spec file difference from Copr build 8371563 to 8371606
Copr build: https://copr.fedorainfracloud.org/coprs/build/8371606 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330124-rust-oid-registry/fedora-rawhide-x86_64/08371606-rust-oid-registry/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package looks good to me, though I wonder why you changed the Summary? Prefixing it with "Rust " is redundant if the package name is already "rust-", and only adds maintenance overhead for you. I added the "Rust" prefix as I seen it on a previous example. I removed it in the latest spec changes and will post them. Thanks for the review. Spec URL: https://raw.githubusercontent.com/tylerfanelli/f42-rust-oid-registry-candidate/refs/heads/main/rust-oid-registry.spec SRPM URL: https://github.com/tylerfanelli/f42-rust-oid-registry-candidate/raw/refs/heads/main/rust-oid-registry-0.7.1-1.fc42.src.rpm Description: Rust Object Identifier (OID) database Fedora Account System Username: tfanelli Ah, the description identifier should be different. I changed in the spec. Spec URL: https://raw.githubusercontent.com/tylerfanelli/f42-rust-oid-registry-candidate/refs/heads/main/rust-oid-registry.spec SRPM URL: https://github.com/tylerfanelli/f42-rust-oid-registry-candidate/raw/refs/heads/main/rust-oid-registry-0.7.1-1.fc42.src.rpm Description: Object Identifier (OID) database Fedora Account System Username: tfanelli Copr build: https://copr.fedorainfracloud.org/coprs/build/8373468 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330124-rust-oid-registry/fedora-rawhide-x86_64/08373468-rust-oid-registry/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/8373474 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330124-rust-oid-registry/fedora-rawhide-x86_64/08373474-rust-oid-registry/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Note that the linked spec file now mismatches with the spec file in the linked SRPM file. I trust that you will import the correct version though (since it's just a cosmetic change). Yea, I'll rebuild the SRPM with the correct spec file. I've tried `fedpkg request-repo rust-oid-registry 2330124`, but was met with: Could not execute request_repo: The Bugzilla bug is not approved yet I've rebuilt the SRPM with the correct spec file. Does this need further approval? Spec URL: https://raw.githubusercontent.com/tylerfanelli/f42-rust-oid-registry-candidate/refs/heads/main/rust-oid-registry.spec SRPM URL: https://github.com/tylerfanelli/f42-rust-oid-registry-candidate/raw/refs/heads/main/rust-oid-registry-0.7.1-1.fc42.src.rpm Description: Object Identifier (OID) database Fedora Account System Username: tfanelli Created attachment 2062027 [details]
The .spec file difference from Copr build 8373474 to 8374683
Copr build: https://copr.fedorainfracloud.org/coprs/build/8374683 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330124-rust-oid-registry/fedora-rawhide-x86_64/08374683-rust-oid-registry/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I think Fabio forgot to set fedora-review+ with Comment #15, setting it now Yes, sorry, I did miss that. However, the account which sets the fedora-review+ flag must match the bug assignee, otherwise the ticket is considered invalid. So I'll fix that now. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-oid-registry FEDORA-2024-c4f93f9f0e (rust-oid-registry-0.7.1-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-c4f93f9f0e FEDORA-2024-c4f93f9f0e (rust-oid-registry-0.7.1-2.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. *** Bug 2312640 has been marked as a duplicate of this bug. *** |