Bug 2312637 (rust-asn1-rs) - Review Request: rust-asn1-rs - Parser/encoder for ASN.1 BER/DER data
Summary: Review Request: rust-asn1-rs - Parser/encoder for ASN.1 BER/DER data
Keywords:
Status: CLOSED ERRATA
Alias: rust-asn1-rs
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/asn1-rs
Whiteboard:
: 2330103 (view as bug list)
Depends On: 2312629 2312632 2312634
Blocks: rust-der-parser 2330123 2330124
TreeView+ depends on / blocked
 
Reported: 2024-09-16 19:54 UTC by Davide Cavalca
Modified: 2024-12-08 10:25 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-12-08 10:25:26 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2024-09-16 19:54:57 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-asn1-rs/rust-asn1-rs.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-asn1-rs/rust-asn1-rs-0.6.2-1.fc42.src.rpm

Description:
Parser/encoder for ASN.1 BER/DER data.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-09-16 19:55:50 UTC
$ cat rust2rpm.toml 
[requires]
test = [
  "crate(bitvec)",
  "crate(cookie-factory)",
  "crate(num-bigint)",
  "crate(time)",
  "crate(time-macros)",
]

Comment 2 Fedora Review Service 2024-09-16 19:57:16 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8025100
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2312637-rust-asn1-rs/fedora-rawhide-x86_64/08025100-rust-asn1-rs/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2024-11-07 21:25:22 UTC
[fedora-review-service-build]

Comment 4 Fedora Review Service 2024-11-07 21:27:27 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8229471
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2312637-rust-asn1-rs/fedora-rawhide-x86_64/08229471-rust-asn1-rs/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Marc-Andre Lureau 2024-11-27 13:09:34 UTC
@davide you need to update the buildrequires list:
%if %{with check}
BuildRequires:  crate(bitvec)
BuildRequires:  crate(cookie-factory)
BuildRequires:  crate(futures)
BuildRequires:  crate(futures-macro)
BuildRequires:  crate(futures-executor)
BuildRequires:  crate(num-bigint)
BuildRequires:  crate(slab)
BuildRequires:  crate(time)
BuildRequires:  crate(time-macros)
%endif

Comment 6 Fabio Valentini 2024-11-27 16:25:18 UTC
(In reply to Marc-Andre Lureau from comment #5)
> @davide you need to update the buildrequires list:
> %if %{with check}
> BuildRequires:  crate(bitvec)
> BuildRequires:  crate(cookie-factory)
> BuildRequires:  crate(futures)
> BuildRequires:  crate(futures-macro)
> BuildRequires:  crate(futures-executor)
> BuildRequires:  crate(num-bigint)
> BuildRequires:  crate(slab)
> BuildRequires:  crate(time)
> BuildRequires:  crate(time-macros)
> %endif

I don't know why this is here or why you both think it's required - adding crate dependencies like this is wrong either way, especially without lower / upper version bounds.

If the dependencies are missing from the crate, they should be added in Cargo.toml (how that is possible, I don't know), or if the dependencies are needed for tests and they're pulled in by optional / non-default features, add the "-f foo,bar" or even "-a" flag to "%cargo_*" macros (except %cargo_prep) instead.

Comment 8 Davide Cavalca 2024-11-27 17:46:52 UTC
$ cat rust2rpm.toml 
[features]
# These need to be enables for the tests to work
enable = [
  "bigint",
  "bits",
  "datetime",
  "serialize",
]

Comment 9 Fedora Review Service 2024-11-27 18:04:49 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8319579
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2312637-rust-asn1-rs/fedora-rawhide-x86_64/08319579-rust-asn1-rs/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Fabio Valentini 2024-12-05 19:25:02 UTC
*** Bug 2330103 has been marked as a duplicate of this bug. ***

Comment 11 Fabio Valentini 2024-12-05 19:26:36 UTC
Taking this review.

Comment 12 Fabio Valentini 2024-12-05 19:44:17 UTC
Package was generated with rust2rpm, simplifying the review.

You might want to exclude the "doc/" folder but it doesn't hurt to be present since it's just some markdown files.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 13 Fedora Admin user for bugzilla script actions 2024-12-08 09:36:29 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-asn1-rs

Comment 14 Fedora Update System 2024-12-08 10:20:44 UTC
FEDORA-2024-45784f5560 (rust-asn1-rs-0.6.2-2.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-45784f5560

Comment 15 Fedora Update System 2024-12-08 10:25:26 UTC
FEDORA-2024-45784f5560 (rust-asn1-rs-0.6.2-2.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.