Bug 2330385

Summary: Review Request: OpenCL-ICD-Loader - Khronos official OpenCL ICD Loader
Product: [Fedora] Fedora Reporter: František Zatloukal <fzatlouk>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ngompa13, package-review, yselkowi
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: ngompa13: fedora-review+
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/KhronosGroup/OpenCL-ICD-Loader
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-12-05 23:42:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description František Zatloukal 2024-12-04 17:35:39 UTC
SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/OpenCL-ICD-Loader-Review/fedora-rawhide-x86_64/08341254-OpenCL-ICD-Loader/OpenCL-ICD-Loader.spec

SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/OpenCL-ICD-Loader-Review/fedora-rawhide-x86_64/08341254-OpenCL-ICD-Loader/OpenCL-ICD-Loader-3.0.6-1.20241023git5907ac1.fc42.src.rpm

This is an alternative OpenCL Loader to already packaged ocl-icd. Some time ago I've got a request that it may be beneficiary for some compute workloads to include the Khronos provided icd implementation. 

It may become the default one one day, however, I do not "know enough" to propose that, so this is plainly an alternative implementation that provides libOpenCL.so .

I wasn't sure for the version field - it now uses the "loader exposed version".

Comment 1 Fedora Review Service 2024-12-04 17:35:53 UTC
The ticket summary is not in the correct format.
Expected:

    Review Request: <main package name here> - <short summary here>

Found:

    Review Request: OpenCL-ICD-Loader: Khronos official OpenCL ICD Loader

As a consequence, the package name cannot be parsed and submitted to
be automatically build. Please modify the ticket summary and trigger a
build by typing [fedora-review-service-build].


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2024-12-04 17:47:51 UTC
Taking this review.

Comment 3 Neal Gompa 2024-12-04 18:04:46 UTC
[fedora-review-service-build]

Comment 4 Fedora Review Service 2024-12-04 18:10:45 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8341598
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330385-opencl-icd-loader/fedora-rawhide-x86_64/08341598-OpenCL-ICD-Loader/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Neal Gompa 2024-12-05 19:06:58 UTC
> Conflicts: ocl-icd
> Conflicts: ocl-icd-devel

We probably want virtual provides+conflicts to make them equivalent providers eventually.

Comment 6 Neal Gompa 2024-12-05 19:21:38 UTC
Review notes:

* Package follows packaging guidelines
* Package builds and installs
* Package conflicts are correct
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 7 Fedora Admin user for bugzilla script actions 2024-12-05 23:27:30 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/OpenCL-ICD-Loader

Comment 8 Fedora Update System 2024-12-05 23:39:23 UTC
FEDORA-2024-e9099a34d5 (OpenCL-ICD-Loader-3.0.6-1.20241023git5907ac1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e9099a34d5

Comment 9 Fedora Update System 2024-12-05 23:42:23 UTC
FEDORA-2024-e9099a34d5 (OpenCL-ICD-Loader-3.0.6-1.20241023git5907ac1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Yaakov Selkowitz 2024-12-17 02:06:00 UTC
There are now conflicting ICD loaders in both F41 and rawhide (F42), this and ocl-icd.  Which and by what criteria should I choose one (e.g. for flatpak runtimes)?  What value is there to having both?

Comment 11 Red Hat Bugzilla 2025-04-17 04:25:08 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days