Bug 2332263
| Summary: | Review Request: mkdocs-bootswatch - Bootswatch themes for MkDocs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | michel, package-review |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://mkdocs.github.io/mkdocs-bootswatch | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-12-16 11:58:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Davide Cavalca
2024-12-13 11:12:20 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=126792958 This package will need to be unretired: https://src.fedoraproject.org/rpms/mkdocs-bootswatch Copr build: https://copr.fedorainfracloud.org/coprs/build/8389600 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332263-mkdocs-bootswatch/fedora-rawhide-x86_64/08389600-mkdocs-bootswatch/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was unretired and the diff from the previous spec (F35) is reasonable, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the sotware is packaged - license matches upstream specification (BSD-2-Clause AND MIT) and is acceptable for Fedora - license file is included with %license in %files note - only BSD-2-Clause? I can't see the MIT license file - package complies with the Python Packaging Guidelines Package APPROVED. === Recommended post-import python-packagers-sig tasks (use `fedora-sig-onboard onboard pkgname`: - add @python-packagers-sig with "commit" access as package co-maintainer - track package in koschei for all built branches Ah. so there are two license files /usr/lib/python3.13/site-packages/mkdocs_bootswatch-1.1.dist-info/LICENSE gets automatically bundled bootswatch.LICENSE (which is MIT) does not get automatically bundled so you need to add this by hand Unretirement ticket: https://pagure.io/releng/issue/12502 FEDORA-2024-d0bc2f3c92 (mkdocs-bootswatch-1.1-7.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-d0bc2f3c92 FEDORA-2024-d0bc2f3c92 (mkdocs-bootswatch-1.1-7.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |