Bug 2332263 - Review Request: mkdocs-bootswatch - Bootswatch themes for MkDocs
Summary: Review Request: mkdocs-bootswatch - Bootswatch themes for MkDocs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: http://mkdocs.github.io/mkdocs-bootsw...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-12-13 11:12 UTC by Davide Cavalca
Modified: 2024-12-16 11:58 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-12-16 11:58:52 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2024-12-13 11:12:20 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/mkdocs-bootswatch/mkdocs-bootswatch.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/mkdocs-bootswatch/mkdocs-bootswatch-1.1-7.src.rpm

Description:
Bootswatch themes for MkDocs.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-12-13 11:12:23 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=126792958

Comment 2 Davide Cavalca 2024-12-13 11:12:40 UTC
This package will need to be unretired: https://src.fedoraproject.org/rpms/mkdocs-bootswatch

Comment 3 Fedora Review Service 2024-12-13 11:15:00 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8389600
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332263-mkdocs-bootswatch/fedora-rawhide-x86_64/08389600-mkdocs-bootswatch/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Michel Lind 2024-12-13 11:58:28 UTC
Package was unretired and the diff from the previous spec (F35) is reasonable, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the sotware is packaged
- license matches upstream specification (BSD-2-Clause AND MIT) and is acceptable for Fedora
- license file is included with %license in %files
  note - only BSD-2-Clause? I can't see the MIT license file
- package complies with the Python Packaging Guidelines

Package APPROVED.

===

Recommended post-import python-packagers-sig tasks (use `fedora-sig-onboard onboard pkgname`:

- add @python-packagers-sig with "commit" access as package co-maintainer

- track package in koschei for all built branches

Comment 5 Michel Lind 2024-12-13 12:01:53 UTC
Ah. so there are two license files

/usr/lib/python3.13/site-packages/mkdocs_bootswatch-1.1.dist-info/LICENSE gets automatically bundled

bootswatch.LICENSE (which is MIT) does not get automatically bundled so you need to add this by hand

Comment 6 Davide Cavalca 2024-12-13 12:02:29 UTC
Unretirement ticket: https://pagure.io/releng/issue/12502

Comment 7 Fedora Update System 2024-12-16 11:56:06 UTC
FEDORA-2024-d0bc2f3c92 (mkdocs-bootswatch-1.1-7.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-d0bc2f3c92

Comment 8 Fedora Update System 2024-12-16 11:58:52 UTC
FEDORA-2024-d0bc2f3c92 (mkdocs-bootswatch-1.1-7.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.