Bug 2332834

Summary: Review Request: Qt-Advanced-Docking-System - Advanced Docking System for Qt
Product: [Fedora] Fedora Reporter: Steve Cossette <farchord>
Component: Package ReviewAssignee: Onuralp Sezer <thunderbirdtr>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review, thunderbirdtr
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: thunderbirdtr: fedora-review+
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-05-23 20:26:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
The .spec file difference from Copr build 8403295 to 9073556 none

Comment 1 Fedora Review Service 2024-12-17 14:27:01 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8403295
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332834-qt-advanced-docking-system/fedora-rawhide-x86_64/08403295-Qt-Advanced-Docking-System/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Onuralp Sezer 2025-05-22 14:47:46 UTC
Steve let's update this package to 4.4.0 and re-do copr build and check it out (https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System/releases/tag/4.4.0)

Comment 4 Fedora Review Service 2025-05-22 16:20:08 UTC
Created attachment 2091136 [details]
The .spec file difference from Copr build 8403295 to 9073556

Comment 5 Fedora Review Service 2025-05-22 16:20:10 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9073556
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332834-qt-advanced-docking-system/fedora-rawhide-x86_64/09073556-Qt-Advanced-Docking-System/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Onuralp Sezer 2025-05-23 11:59:57 UTC
[fedora-review-service-build]

Comment 9 Onuralp Sezer 2025-05-23 14:15:53 UTC
[fedora-review-service-build]

Comment 10 Onuralp Sezer 2025-05-23 17:38:49 UTC
[fedora-review-service-build]

Comment 11 Fedora Review Service 2025-05-23 17:42:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9076023
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332834-qt-advanced-docking-system/fedora-rawhide-x86_64/09076023-Qt-Advanced-Docking-System/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 12 Fedora Review Service 2025-05-23 17:52:45 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9076025
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332834-qt-advanced-docking-system/fedora-rawhide-x86_64/09076025-Qt-Advanced-Docking-System/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 13 Onuralp Sezer 2025-05-23 19:57:15 UTC
* Package follows Fedora packaging guidelines
* Package builds and installs
* Package licensing looks correct
* No serious issues in rpmlint

Everything looks good, so...

PACKAGE APPROVED.

Comment 14 Steve Cossette 2025-05-23 20:01:24 UTC
Thank you for the review, Onuralp

Comment 15 Fedora Admin user for bugzilla script actions 2025-05-23 20:01:54 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/Qt-Advanced-Docking-System