Spec URL: https://farchord.fedorapeople.org/reviews/Qt-Advanced-Docking-System/Qt-Advanced-Docking-System.spec SRPM URL: https://farchord.fedorapeople.org/reviews/Qt-Advanced-Docking-System/Qt-Advanced-Docking-System-4.3.1-1.fc41.src.rpm Description: Advanced Docking System for Qt. Fedora Account System Username: farchord
Copr build: https://copr.fedorainfracloud.org/coprs/build/8403295 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332834-qt-advanced-docking-system/fedora-rawhide-x86_64/08403295-Qt-Advanced-Docking-System/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Steve let's update this package to 4.4.0 and re-do copr build and check it out (https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System/releases/tag/4.4.0)
Spec URL: https://farchord.fedorapeople.org/reviews/Qt-Advanced-Docking-System/Qt-Advanced-Docking-System.spec SRPM URL: https://farchord.fedorapeople.org/reviews/Qt-Advanced-Docking-System/Qt-Advanced-Docking-System-4.4.0-1.fc42.src.rpm - 4.4.0
Created attachment 2091136 [details] The .spec file difference from Copr build 8403295 to 9073556
Copr build: https://copr.fedorainfracloud.org/coprs/build/9073556 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332834-qt-advanced-docking-system/fedora-rawhide-x86_64/09073556-Qt-Advanced-Docking-System/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Spec URL: https://farchord.fedorapeople.org/reviews/Qt-Advanced-Docking-System/Qt-Advanced-Docking-System.spec SRPM URL: https://farchord.fedorapeople.org/reviews/Qt-Advanced-Docking-System/Qt-Advanced-Docking-System-4.4.0-1.fc42.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/9076023 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332834-qt-advanced-docking-system/fedora-rawhide-x86_64/09076023-Qt-Advanced-Docking-System/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9076025 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332834-qt-advanced-docking-system/fedora-rawhide-x86_64/09076025-Qt-Advanced-Docking-System/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
* Package follows Fedora packaging guidelines * Package builds and installs * Package licensing looks correct * No serious issues in rpmlint Everything looks good, so... PACKAGE APPROVED.
Thank you for the review, Onuralp
The Pagure repository was created at https://src.fedoraproject.org/rpms/Qt-Advanced-Docking-System