Bug 2333205

Summary:	Review Request: python-hjson - User interface for JSON
Product:	[Fedora] Fedora	Reporter:	Davide Cavalca <davide>
Component:	Package Review	Assignee:	Michel Lind <michel>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	michel, package-review
Target Milestone:	---	Flags:	michel: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://hjson.github.io
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-12-29 22:01:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2333293, 2333206

Description Davide Cavalca 2024-12-19 07:33:34 UTC

Spec URL: https://dcavalca.fedorapeople.org/review/python-hjson/python-hjson.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/python-hjson/python-hjson-3.1.0-1.fc42.src.rpm

Description:
This package is a Python implementation of Hjson is based on simplejson.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-12-19 07:33:37 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=127007949

Comment 2 Fedora Review Service 2024-12-20 00:39:45 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8422618
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333205-python-hjson/fedora-rawhide-x86_64/08422618-python-hjson/fedora-review/review.txt

Found issues:

- python3-pytest7 is deprecated, you must not depend on it.
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2024-12-27 20:35:22 UTC

nit: summary is weird to read, I think the last 'is' is superfluous

Comment 4 Michel Lind 2024-12-27 21:04:17 UTC

The pytest issue is a false positive, this actually uses pytest 8

Apart from the description, everything else is fine. Please fix when importing

Package was generated with pyp2spec, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the sotware is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with the Python Packaging Guidelines

Package APPROVED.

===

Recommended post-import python-packagers-sig tasks (use `fedora-sig-onboard onboard pkgname`:

- add @python-packagers-sig with "commit" access as package co-maintainer

- track package in koschei for all built branches

Comment 5 Fedora Admin user for bugzilla script actions 2024-12-29 21:44:39 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-hjson

Comment 6 Fedora Update System 2024-12-29 21:57:28 UTC

FEDORA-2024-79028c9cea (python-hjson-3.1.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-79028c9cea

Comment 7 Fedora Update System 2024-12-29 22:01:50 UTC

FEDORA-2024-79028c9cea (python-hjson-3.1.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.