Spec URL: https://dcavalca.fedorapeople.org/review/python-hjson/python-hjson.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-hjson/python-hjson-3.1.0-1.fc42.src.rpm Description: This package is a Python implementation of Hjson is based on simplejson. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=127007949
Copr build: https://copr.fedorainfracloud.org/coprs/build/8422618 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333205-python-hjson/fedora-rawhide-x86_64/08422618-python-hjson/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
nit: summary is weird to read, I think the last 'is' is superfluous
The pytest issue is a false positive, this actually uses pytest 8 Apart from the description, everything else is fine. Please fix when importing Package was generated with pyp2spec, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the sotware is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with the Python Packaging Guidelines Package APPROVED. === Recommended post-import python-packagers-sig tasks (use `fedora-sig-onboard onboard pkgname`: - add @python-packagers-sig with "commit" access as package co-maintainer - track package in koschei for all built branches
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-hjson
FEDORA-2024-79028c9cea (python-hjson-3.1.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-79028c9cea
FEDORA-2024-79028c9cea (python-hjson-3.1.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.