Bug 2333289

Summary: Review Request: python-mkdocs-d2-plugin - D2 plugin for MkDocs
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: michel: fedora-review+
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/landmaj/mkdocs-d2-plugin
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-02-28 22:44:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2333284    
Bug Blocks: 2333293, 2337407    

Description Davide Cavalca 2024-12-19 09:18:55 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/python-mkdocs-d2-plugin/python-mkdocs-d2-plugin.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/python-mkdocs-d2-plugin/python-mkdocs-d2-plugin-1.6.0-1.fc42.src.rpm

Description:
This package provides a plugin for embedding D2 diagrams in MkDocs.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-12-19 09:18:58 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=127010123

Comment 2 Fedora Review Service 2024-12-20 00:35:20 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8422568
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333289-python-mkdocs-d2-plugin/fedora-rawhide-x86_64/08422568-python-mkdocs-d2-plugin/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2025-02-28 22:33:41 UTC
Looks fine - but you probably want to flip the Recommends: d2 back to Requires now that it's actually in Fedora?

Package was generated with pyp2spec, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the software is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with the Python Packaging Guidelines

Package APPROVED.

===

Recommended post-import python-packagers-sig tasks (use `fedora-sig-onboard onboard pkgname`:

- add @python-packagers-sig with "commit" access as package co-maintainer

- track package in koschei for all built branches

Comment 4 Fedora Admin user for bugzilla script actions 2025-02-28 22:34:59 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-mkdocs-d2-plugin

Comment 5 Fedora Update System 2025-02-28 22:41:57 UTC
FEDORA-2025-9398cb6820 (python-mkdocs-d2-plugin-1.6.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-9398cb6820

Comment 6 Fedora Update System 2025-02-28 22:44:50 UTC
FEDORA-2025-9398cb6820 (python-mkdocs-d2-plugin-1.6.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.