Bug 2333284 - Review Request: d2 - Modern diagram scripting language that turns text to diagrams
Summary: Review Request: d2 - Modern diagram scripting language that turns text to dia...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2333293 2337407 2333289
TreeView+ depends on / blocked
 
Reported: 2024-12-19 09:04 UTC by Davide Cavalca
Modified: 2025-02-26 00:05 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-02-26 00:05:48 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2024-12-19 09:04:20 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/d2/d2.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/d2/d2-0.6.8-1.fc42.src.rpm

Description:
D2 is a modern diagram scripting language that turns text to diagrams.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-12-19 09:04:22 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=127009556

Comment 2 Davide Cavalca 2024-12-19 09:12:10 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/d2/d2.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/d2/d2-0.6.8-1.fc42.src.rpm

Changelog:
- drop unnecessary binary

Comment 3 Davide Cavalca 2024-12-19 09:13:15 UTC
First time doing golang vendoring, so a thorough review would be appreciated. In particular, I'd like to find a way to only disable the tests that actually fail (notably, the ones using Playwright as they attempt to install it from the Internet).

Comment 4 Fedora Review Service 2024-12-20 00:38:44 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8422565
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333284-d2/fedora-rawhide-x86_64/08422565-d2/fedora-review/review.txt

Found issues:

- Documentation size is 8825393 bytes in 35 files. 
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fedora Review Service 2024-12-20 00:39:20 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8422564
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333284-d2/fedora-rawhide-x86_64/08422564-d2/fedora-review/review.txt

Found issues:

- Documentation size is 8825393 bytes in 35 files. 
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Michel Lind 2024-12-27 21:13:44 UTC
(In reply to Davide Cavalca from comment #3)
> First time doing golang vendoring, so a thorough review would be
> appreciated. In particular, I'd like to find a way to only disable the tests
> that actually fail (notably, the ones using Playwright as they attempt to
> install it from the Internet).

I have yet to find a way to disable individual tests myself. I've previously resorted to deleting test files, which is about as coarse as what you're doing here

Comment 7 Michel Lind 2025-02-25 22:58:32 UTC
Package was generated with go2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 AND BSD-2-Clause AND BSD-3-Clause AND FTL AND ISC AND MIT AND MPL-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Golang Packaging Guidelines

Package APPROVED.

===

Recommended post-import go-sig tasks (use `fedora-sig-onboard onboard $goname`:

- add @go-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @go-sig (optional)

- track package in koschei for all built branches

Comment 8 Fedora Admin user for bugzilla script actions 2025-02-25 23:40:37 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/d2

Comment 9 Fedora Update System 2025-02-26 00:02:12 UTC
FEDORA-2025-0630552539 (d2-0.6.8-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-0630552539

Comment 10 Fedora Update System 2025-02-26 00:05:48 UTC
FEDORA-2025-0630552539 (d2-0.6.8-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.