Bug 233602

Spec URL: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/pykdeextensions.spec

Hi Rex, I'm happy to review the package, it might take a few days, but I'll
gradually work over the package as and when I have the breaks to.

I should have it done by the weekend though.

Package name:             PASS (pykdeextensions)
License:                  PASS (LGPL)
Spec Legible:             PASS (en_US)
md5sum matches:           NT
rpmlint clean:            FAIL
Builds correctly:         PASS (i386)
RPaths removed:           FAIL
Spec has %clean:          PASS
Macro use consistant:     PASS
Contains code/content:    PASS
-doc subpackage:          NA
-devel subpackage:        PASS
-static subpackage:       NA
pkgconfig depend:         NA
Contains %doc:            PASS
Library suffix:           NA
No .la files:             NA
Use desktop-file-install: NA
No duplicate ownerships:  PASS
rm -rf %{buildroot}:      PASS
RPM uses valid UTF-8:     PASS
%defattr is set:          PASS
No duplicate %files:      PASS
Not relocatable:          PASS
Calls ldconfig:           PASS
Supports Locales:         NA
BR's are correct:         NT

NA - Not Applicable
NT - Not Tested

rpmlint on build RPMS:
E: pykdeextensions non-executable-script
/usr/lib/python2.4/site-packages/kdedistutils.py 0644
E: pykdeextensions non-executable-script
/usr/lib/python2.4/site-packages/qtuicompiler.py 0644
E: pykdeextensions zero-length /usr/share/doc/pykdeextensions-0.4.0/NEWS
E: pykdeextensions binary-or-shlib-defines-rpath /usr/lib/libpythonize.so.0.0.0
['/usr/lib']
E: pykdeextensions-devel non-executable-script
/usr/share/apps/pykdeextensions/app_templates/kdeapp/src/prefdialog.py 0644

rpmlint on SRPM:
W: pykdeextensions patch-not-applied Patch1: pykdeextensions-0.4.0-rpath.patch 

Happy to ignore the patch-not-applied, NEWS could nearly be removed though.

Other notes:
rpm -qlp produced:

/usr/share/apps/pykdeextensions/app_templates/kdeapp/AUTHORS
/usr/share/apps/pykdeextensions/app_templates/kdeapp/COPYING
/usr/share/apps/pykdeextensions/app_templates/kdeapp/INSTALL
/usr/share/apps/pykdeextensions/app_templates/kdeapp/MANIFEST.in
/usr/share/apps/pykdeextensions/app_templates/kdeutility/AUTHORS
/usr/share/apps/pykdeextensions/app_templates/kdeutility/COPYING
/usr/share/apps/pykdeextensions/app_templates/kdeutility/INSTALL
/usr/share/apps/pykdeextensions/app_templates/kdeutility/MANIFEST.in

I assume the files are needed...

In summary: If you can fix the rpath and non-executable-script's I'll run I
final test in mock.

Rex, The SRPM url seem down, could you fix this ?

(In reply to comment #4)
> Rex, The SRPM url seem down, could you fix this ?
> 
> 

It's an apt repository, so of course it appears down, it got moved from testing
to stable, no big deal.

http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/pykdeextensions/pykdeextensions.spec
http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/pykdeextensions/pykdeextensions-0.4.0-2.src.rpm

%changelog
* Fri Jul 13 2007 Rex Dieter <rdieter[AT]fedoraproject.org> 0.4.0-2
- omit empty NEWS
- use chrpath to fix rpath issue(s)

Package name:             PASS (pykdeextensions)
License:                  PASS (LGPL)
Spec Legible:             PASS (en_US)
md5sum matches:           PASS (5249c7288c1b2bed44a2d91111d3313a)
rpmlint clean:            NOTES
Builds correctly:         PASS (i386)
RPaths removed:           PASS
Spec has %clean:          PASS
Macro use consistant:     PASS
Contains code/content:    PASS
-doc subpackage:          NA
-devel subpackage:        PASS
-static subpackage:       NA
pkgconfig depend:         NA
Contains %doc:            PASS
Library suffix:           NA
No .la files:             NA
Use desktop-file-install: NA
No duplicate ownerships:  PASS
rm -rf %{buildroot}:      PASS
RPM uses valid UTF-8:     PASS
%defattr is set:          PASS
No duplicate %files:      PASS
Not relocatable:          PASS
Calls ldconfig:           PASS
Supports Locales:         NA
BR's are correct:         PASS

NA - Not Applicable
NT - Not Tested

rpmlint on build RPMS:
E: pykdeextensions non-executable-script
/usr/lib/python2.5/site-packages/qtuicompiler.py 0644
E: pykdeextensions non-executable-script
/usr/lib/python2.5/site-packages/kdedistutils.py 0644
E: pykdeextensions-devel non-executable-script
/usr/share/apps/pykdeextensions/app_templates/kdeapp/src/prefdialog.py 0644

I'm assuming these scripts are meant to be non-executable, so APPROVED

Oh, and If you do need a comaintainer, let me know.

I'll take you up on the comaint offer...

New Package CVS Request
=======================
Package Name: pykdeextensions
Short Description: A collection of python packages to support KDE applications
Owners: rdieter.edu,dev
Branches: F-7 FC-6
InitialCC: 

Make that 

Branches: EL-4 EL-5 F-7 FC-6

All the dependencies seem to be there (but I confess I havn't tried building 
yet)

cvs done.

While this review went through I never saw any packages in devel or the other 
branches. What happened?

I was going to do pykdeextensions and guidance together, but guidance still
needs a lot of work.

If there's need/interest for pykdeextensions alone, I have no problem doing that
ealier.

Since I withdrew guidance review (bug #233603), I'm going to withdraw this one 
too.

Anyone is welcome to pick this up (to maintain) if they so desire.