Bug 2336118

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8480919
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2336118-composable_kernel/fedora-rawhide-x86_64/08480919-composable_kernel/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

gcc 15 causes this is issue, that will need to be resolved.

In file included from /usr/include/hip/hip_runtime.h:62:
In file included from /usr/include/hip/amd_detail/amd_hip_runtime.h:114:
In file included from /usr/include/hip/hip_runtime_api.h:575:
In file included from /usr/include/hip/texture_types.h:47:
In file included from /usr/include/hip/channel_descriptor.h:32:
In file included from /usr/include/hip/amd_detail/amd_channel_descriptor.h:29:
In file included from /usr/include/hip/amd_detail/amd_hip_vector_types.h:49:
/usr/lib/gcc/x86_64-redhat-linux/15/../../../../include/c++/15/array:219:2: error: reference to __host__ function '__glibcxx_assert_fail' in __host__ __device__ function
  219 |         __glibcxx_requires_subscript(__n);
      |         ^
/usr/lib/gcc/x86_64-redhat-linux/15/../../../../include/c++/15/debug/assertions.h:39:3: note: expanded from macro '__glibcxx_requires_subscript'
   39 |   __glibcxx_assert(_N < this->size())
      |   ^
/usr/lib/gcc/x86_64-redhat-linux/15/../../../../include/c++/15/x86_64-redhat-linux/bits/c++config.h:2553:12: note: expanded from macro '__glibcxx_assert'
 2553 |       std::__glibcxx_assert_fail();                                     \
      |            ^
/builddir/build/BUILD/composable_kernel-6.3.2-build/composable_kernel-rocm-6.3.2/include/ck/tensor_operation/gpu/device/impl/device_batched_gemm_multiple_d_gemm_multiple_d_xdl_cshuffle.hpp:410:54: note: called by 'GetD0BasePtr<0>'
  410 |             return g_idx * static_cast<long_index_t>(BatchStrideD0s_[d1_idx]);
      |                                                      ^
/builddir/build/BUILD/composable_kernel-6.3.2-build/composable_kernel-rocm-6.3.2/include/ck/tensor_operation/gpu/device/impl/device_batched_gemm_multiple_d_gemm_multiple_d_xdl_cshuffle.hpp:89:65: note: called by 'operator()<ck::integral_constant<int, 0>>'
   89 |             static_cast<long_index_t>(compute_base_ptr_of_batch.GetD0BasePtr(g_idx, In)));

Spec URL: https://trix.fedorapeople.org/composable_kernel.spec
SRPM URL: https://trix.fedorapeople.org/composable_kernel-6.3.3-1.fc43.src.rpm

A refresh to the latest source.
The assert was handled by a change to the compiler.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8795690
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2336118-composable_kernel/fedora-rawhide-x86_64/08795690-composable_kernel/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Spec URL: https://trix.fedorapeople.org/composable_kernel.spec
SRPM URL: https://trix.fedorapeople.org/composable_kernel-6.4.1-1.fc43.src.rpm

Refresh to the latest ROCm version
Reduce gpu set to avoid timeout.

Spec URL: https://trix.fedorapeople.org/composable_kernel.spec
SRPM URL: https://trix.fedorapeople.org/composable_kernel-6.4.2-1.fc43.src.rpm

Update latest ROCm 6.4.2

This review has been in progress for a while but it's basically complete. I have some concerns about this package but those don't affect the review much.

1. This is only built for a single ISA, unlike the rest of ROCm
   - This is a response to the crazy build time for this package. Enabling all the standard ISAs will cause the build to timeout in koji so we don't really have a choice on this one
   - c_k has a more narrow list of supported ISAs than most of the rest of the ROCm packages so there's not really a point in enabling more than what that specific upstream is willing to support
   - I don't know where to make note of this since it's not obvious unless you look at the specfile which most users won't do

2. The tests don't do terribly well for the single ISA that this is built for
   - This is not unique to the packaged form of c_k, building non-packaged, vanilla upstream for gfx1100 has the same failures

3. The structure of the optional test subpackage needs some tweaking
   - I'll just make these changes post-review, none of my concerns are in scope for the review, especially seeing as how the test subpackage is not built by default and can't be built in koji

The only thing I want to see changed before approving the review is some sort of user-facing documentation about which ISA(s) the package is built for or at least a comment that it is more limited than the rest of ROCm. I don't care if it's in the description or some kind of README added to the package so long as it's somewhere that a user can reasonably find.

The single isa was chosen to make both the review easier and to defer the problem with koji, the isa's will be added until koji has problems.

I have created and added ck to a list of exceptions to general gpu support here
https://fedoraproject.org/wiki/SIGs/HC#Packages_with_limited_gpu_support

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* MIT License", "MIT
     License". 458 files have unknown license. Detailed output of
     licensecheck in
     /home/tflink/packages/reviews/2336118-composable_kernel/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/include/ck(ck-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 8588 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[!]: %check is present and all tests pass.
NOTE: checks require specific HW not present in koji, it is not possible to enable %check generally
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: composable_kernel-6.4.2-1.fc43.x86_64.rpm
          composable_kernel-devel-6.4.2-1.fc43.x86_64.rpm
          composable_kernel-6.4.2-1.fc43.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmphu907j30')]
checks: 32, packages: 3

composable_kernel.x86_64: W: no-documentation
composable_kernel.spec: W: no-%check-section
 3 packages and 0 specfiles checked; 0 errors, 2 warnings, 31 filtered, 0 badness; has taken 21.0 s 




Rpmlint (debuginfo)
-------------------
Checking: composable_kernel-debuginfo-6.4.2-1.fc43.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpaxiedm20')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 13 filtered, 0 badness; has taken 46.0 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

composable_kernel.x86_64: W: no-documentation
 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 44 filtered, 0 badness; has taken 10.2 s 



Source checksums
----------------
https://github.com/ROCm/composable_kernel/archive/rocm-6.4.2.tar.gz#/composable_kernel-6.4.2.tar.gz :
  CHECKSUM(SHA256) this package     : 6e2acd889d7558f3be88915f249496394a690dd5d7675c36e4053e3856b51567
  CHECKSUM(SHA256) upstream package : 6e2acd889d7558f3be88915f249496394a690dd5d7675c36e4053e3856b51567


Requires
--------
composable_kernel (rpmlib, GLIBC filtered):
    libamdhip64.so.6()(64bit)
    libamdhip64.so.6(hip_4.2)(64bit)
    libamdhip64.so.6(hip_6.0)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.5)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    rtld(GNU_HASH)

composable_kernel-devel (rpmlib, GLIBC filtered):
    cmake-filesystem(x86-64)
    composable_kernel(x86-64)
    libdevice_conv_operations.so.1()(64bit)
    libdevice_gemm_operations.so.1()(64bit)
    libdevice_other_operations.so.1()(64bit)
    libdevice_reduction_operations.so.1()(64bit)
    libutility.so.1()(64bit)



Provides
--------
composable_kernel:
    composable_kernel
    composable_kernel(x86-64)
    libdevice_conv_operations.so.1()(64bit)
    libdevice_gemm_operations.so.1()(64bit)
    libdevice_other_operations.so.1()(64bit)
    libdevice_reduction_operations.so.1()(64bit)
    libutility.so.1()(64bit)

composable_kernel-devel:
    cmake(composable_kernel)
    composable_kernel-devel
    composable_kernel-devel(x86-64)
    composable_kernel-static



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-08-01
Command line :/usr/bin/fedora-review -b 2336118
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: Java, Haskell, R, Perl, PHP, Python, SugarActivity, Ocaml, fonts
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

The Pagure repository was created at https://src.fedoraproject.org/rpms/composable_kernel