Bug 2336118 - Review Request: composable_kernel - Performance Portable Programming Model for Machine Learning Tensor Operators
Summary: Review Request: composable_kernel - Performance Portable Programming Model fo...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/ROCm/composable_ke...
Whiteboard:
Depends On:
Blocks: 2334587
TreeView+ depends on / blocked
 
Reported: 2025-01-07 13:03 UTC by Tom.Rix
Modified: 2025-03-20 03:39 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
Tom.Rix: fedora-review?


Attachments (Terms of Use)

Description Tom.Rix 2025-01-07 13:03:19 UTC
Spec URL: https://trix.fedorapeople.org/composable_kernel.spec
SRPM URL: https://trix.fedorapeople.org/composable_kernel-6.3.1-1.fc42.src.rpm

Composable Kernel (CK) library aims to provide a programming
model for writing performance critical kernels for machine
learning workloads across multiple architectures including
GPUs, CPUs, etc, through general purpose kernel languages,
like HIP C++.

CK utilizes two concepts to achieve performance portability
and code maintainability:

- A tile-based programming model
- Algorithm complexity reduction for complex ML operators,
  using innovative technique we call "Tensor Coordinate
  Transformation".

Reproducible: Always

Comment 1 Fedora Review Service 2025-01-07 18:04:20 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8480919
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2336118-composable_kernel/fedora-rawhide-x86_64/08480919-composable_kernel/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Tom.Rix 2025-02-03 14:56:40 UTC
gcc 15 causes this is issue, that will need to be resolved.

In file included from /usr/include/hip/hip_runtime.h:62:
In file included from /usr/include/hip/amd_detail/amd_hip_runtime.h:114:
In file included from /usr/include/hip/hip_runtime_api.h:575:
In file included from /usr/include/hip/texture_types.h:47:
In file included from /usr/include/hip/channel_descriptor.h:32:
In file included from /usr/include/hip/amd_detail/amd_channel_descriptor.h:29:
In file included from /usr/include/hip/amd_detail/amd_hip_vector_types.h:49:
/usr/lib/gcc/x86_64-redhat-linux/15/../../../../include/c++/15/array:219:2: error: reference to __host__ function '__glibcxx_assert_fail' in __host__ __device__ function
  219 |         __glibcxx_requires_subscript(__n);
      |         ^
/usr/lib/gcc/x86_64-redhat-linux/15/../../../../include/c++/15/debug/assertions.h:39:3: note: expanded from macro '__glibcxx_requires_subscript'
   39 |   __glibcxx_assert(_N < this->size())
      |   ^
/usr/lib/gcc/x86_64-redhat-linux/15/../../../../include/c++/15/x86_64-redhat-linux/bits/c++config.h:2553:12: note: expanded from macro '__glibcxx_assert'
 2553 |       std::__glibcxx_assert_fail();                                     \
      |            ^
/builddir/build/BUILD/composable_kernel-6.3.2-build/composable_kernel-rocm-6.3.2/include/ck/tensor_operation/gpu/device/impl/device_batched_gemm_multiple_d_gemm_multiple_d_xdl_cshuffle.hpp:410:54: note: called by 'GetD0BasePtr<0>'
  410 |             return g_idx * static_cast<long_index_t>(BatchStrideD0s_[d1_idx]);
      |                                                      ^
/builddir/build/BUILD/composable_kernel-6.3.2-build/composable_kernel-rocm-6.3.2/include/ck/tensor_operation/gpu/device/impl/device_batched_gemm_multiple_d_gemm_multiple_d_xdl_cshuffle.hpp:89:65: note: called by 'operator()<ck::integral_constant<int, 0>>'
   89 |             static_cast<long_index_t>(compute_base_ptr_of_batch.GetD0BasePtr(g_idx, In)));

Comment 3 Tom.Rix 2025-03-19 22:38:22 UTC
Spec URL: https://trix.fedorapeople.org/composable_kernel.spec
SRPM URL: https://trix.fedorapeople.org/composable_kernel-6.3.3-1.fc43.src.rpm

A refresh to the latest source.
The assert was handled by a change to the compiler.

Comment 4 Fedora Review Service 2025-03-20 03:39:39 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8795690
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2336118-composable_kernel/fedora-rawhide-x86_64/08795690-composable_kernel/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.