Bug 2338100
| Summary: | Review Request: rust-arcstr - Better reference-counted string type | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/arcstr | ||
| Whiteboard: | Trivial | ||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-01-15 15:58:57 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2337040 | ||
|
Description
Ben Beasley
2025-01-15 03:38:47 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8514732 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2338100-rust-arcstr/fedora-rawhide-x86_64/08514732-rust-arcstr/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. It's almost refreshing to review such a straightforward package :) === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Thank you for the review! Please feel free to ping me on any particularly high-priority reviews you might have. > version filter (*NOT* pre-release filter): alpha;beta;rc;pre Now that we have a “Monitoring stable only” option available in src.fedoraproject.org, we should be able to offer that as alternative, in which case it should be OK to set the pre-release filter and not the version filter on release-monitoring.org. https://release-monitoring.org/project/376417/ (In reply to Ben Beasley from comment #3) > Thank you for the review! Please feel free to ping me on any particularly > high-priority reviews you might have. > > > version filter (*NOT* pre-release filter): alpha;beta;rc;pre > > Now that we have a “Monitoring stable only” option available in > src.fedoraproject.org, we should be able to offer that as alternative, in > which case it should be OK to set the pre-release filter and not the version > filter on release-monitoring.org. Possibly - though versions that contain common strings like "alpha", "beta" and "rc" are already automatically categorized as "pre-releases" by anitya, so you wouldn't even need to set a pre-release filter explicitly. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-arcstr FEDORA-2025-13773a06a1 (rust-arcstr-1.2.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-13773a06a1 FEDORA-2025-13773a06a1 (rust-arcstr-1.2.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-227b92e4c3 (rust-arcstr-1.2.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-227b92e4c3 FEDORA-2025-6c2cb9f5d0 (rust-arcstr-1.2.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-6c2cb9f5d0 FEDORA-2025-227b92e4c3 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-227b92e4c3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-227b92e4c3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-6c2cb9f5d0 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-6c2cb9f5d0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-6c2cb9f5d0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-227b92e4c3 (rust-arcstr-1.2.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-6c2cb9f5d0 (rust-arcstr-1.2.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |