Bug 2338100 - Review Request: rust-arcstr - Better reference-counted string type
Summary: Review Request: rust-arcstr - Better reference-counted string type
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/arcstr
Whiteboard: Trivial
Depends On:
Blocks: 2337040
TreeView+ depends on / blocked
 
Reported: 2025-01-15 03:38 UTC by Ben Beasley
Modified: 2025-01-24 01:32 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-01-15 15:58:57 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Ben Beasley 2025-01-15 03:38:47 UTC
Spec URL: https://music.fedorapeople.org/rust-arcstr.spec
SRPM URL: https://music.fedorapeople.org/rust-arcstr-1.2.0-1.fc41.src.rpm

Description:

A better reference-counted string type, with zero-cost (allocation-free)
support for string literals, and reference counted substrings.

Fedora Account System Username: music

This is a new dependency for uv 0.1.17.

rust2rpm.toml:

[package]
summary = "Better reference-counted string type"

Comment 1 Fedora Review Service 2025-01-15 03:43:33 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8514732
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2338100-rust-arcstr/fedora-rawhide-x86_64/08514732-rust-arcstr/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2025-01-15 13:58:17 UTC
It's almost refreshing to review such a straightforward package :)

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Ben Beasley 2025-01-15 15:04:32 UTC
Thank you for the review! Please feel free to ping me on any particularly high-priority reviews you might have.

>   version filter (*NOT* pre-release filter): alpha;beta;rc;pre

Now that we have a “Monitoring stable only” option available in src.fedoraproject.org, we should be able to offer that as alternative, in which case it should be OK to set the pre-release filter and not the version filter on release-monitoring.org.

https://release-monitoring.org/project/376417/

Comment 4 Fabio Valentini 2025-01-15 15:20:26 UTC
(In reply to Ben Beasley from comment #3)
> Thank you for the review! Please feel free to ping me on any particularly
> high-priority reviews you might have.
> 
> >   version filter (*NOT* pre-release filter): alpha;beta;rc;pre
> 
> Now that we have a “Monitoring stable only” option available in
> src.fedoraproject.org, we should be able to offer that as alternative, in
> which case it should be OK to set the pre-release filter and not the version
> filter on release-monitoring.org.

Possibly - though versions that contain common strings like "alpha", "beta" and "rc" are already automatically categorized as "pre-releases" by anitya, so you wouldn't even need to set a pre-release filter explicitly.

Comment 5 Fedora Admin user for bugzilla script actions 2025-01-15 15:35:03 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-arcstr

Comment 6 Fedora Update System 2025-01-15 15:56:28 UTC
FEDORA-2025-13773a06a1 (rust-arcstr-1.2.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-13773a06a1

Comment 7 Fedora Update System 2025-01-15 15:58:57 UTC
FEDORA-2025-13773a06a1 (rust-arcstr-1.2.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2025-01-15 16:21:11 UTC
FEDORA-2025-227b92e4c3 (rust-arcstr-1.2.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-227b92e4c3

Comment 9 Fedora Update System 2025-01-15 16:54:25 UTC
FEDORA-2025-6c2cb9f5d0 (rust-arcstr-1.2.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-6c2cb9f5d0

Comment 10 Fedora Update System 2025-01-16 02:35:39 UTC
FEDORA-2025-227b92e4c3 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-227b92e4c3 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-227b92e4c3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2025-01-16 02:55:42 UTC
FEDORA-2025-6c2cb9f5d0 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-6c2cb9f5d0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-6c2cb9f5d0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2025-01-24 01:25:21 UTC
FEDORA-2025-227b92e4c3 (rust-arcstr-1.2.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2025-01-24 01:32:00 UTC
FEDORA-2025-6c2cb9f5d0 (rust-arcstr-1.2.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.