Bug 2338679

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8529103
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2338679-rust-const-str-proc-macro/fedora-rawhide-x86_64/08529103-rust-const-str-proc-macro/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Can you file an issue / PR at https://github.com/Nugine/const-str to include the LICENSE file in this subproject too?

Adding a symbolic link "LICENSE -> ../LICENSE" is usually enough, unless the person running "cargo publish" runs this on Windows (the only mainstream OS that doesn't support symbolic links OOTB, yay).

Once that is done, please add a link to that issue / PR alongside the Source URL for the LICENSE file.

Other than that, looks good to me.

(In reply to Fabio Valentini from comment #2)
> Can you file an issue / PR at https://github.com/Nugine/const-str to include
> the LICENSE file in this subproject too?

Done, https://github.com/Nugine/const-str/pull/21

> Adding a symbolic link "LICENSE -> ../LICENSE" is usually enough, unless the
> person running "cargo publish" runs this on Windows (the only mainstream OS
> that doesn't support symbolic links OOTB, yay).

What? Mainstream? :)

> Once that is done, please add a link to that issue / PR alongside the Source
> URL for the LICENSE file.

Added.

> Other than that, looks good to me.

Thanks for picking up this one as well!


Spec URL: https://passt.top/static/rust-const-str-proc-macro.spec
SRPM URL: https://passt.top/static/rust-const-str-proc-macro-0.5.7-1.fc42.src.rpm
Description: Compile-time string operations
Fedora Account System Username: sbrivio

Spec URL: https://passt.top/static/rust-const-str-proc-macro.spec
SRPM URL: https://passt.top/static/rust-const-str-proc-macro-0.5.7-1.fc42.src.rpm
Description: Compile-time string operations
Fedora Account System Username: sbrivio

Created attachment 2067002 [details]
The .spec file difference from Copr build 8529103 to 8558132

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8558132
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2338679-rust-const-str-proc-macro/fedora-rawhide-x86_64/08558132-rust-const-str-proc-macro/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8558146
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2338679-rust-const-str-proc-macro/fedora-rawhide-x86_64/08558146-rust-const-str-proc-macro/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Thanks! Looks good to me now. Two minor things:

1) Please replace "%license LICENSE" with "%license %{crate_instdir}/LICENSE", otherwise the file will be included in the package twice. I would also put the link to the upstream PR next to the Source file for the LICENSE (that's the part that would raise questions), not where it's used (which is normal).

2) Upstream has released version 0.6.0 in the meantime. Is what you're working on explicitly depending on v0.5, or has it bumped its dependency on const-str / const-str-macro to 0.6.0 already? You don't need to update to 0.6.0 if you need 0.5, I'm just asking to make sure you're working on the correct version to avoid more work.

(In reply to Fabio Valentini from comment #8)
> Thanks! Looks good to me now. Two minor things:

Thanks for re-reviewing (and re-re-reviewing, too).

> 1) Please replace "%license LICENSE" with "%license
> %{crate_instdir}/LICENSE", otherwise the file will be included in the
> package twice. I would also put the link to the upstream PR next to the
> Source file for the LICENSE (that's the part that would raise questions),
> not where it's used (which is normal).

Oops. Anyway, not needed anymore, because:

> 2) Upstream has released version 0.6.0 in the meantime.

...which includes my LICENSE symlink. It's 0.6.1 now.

> Is what you're
> working on explicitly depending on v0.5, or has it bumped its dependency on
> const-str / const-str-macro to 0.6.0 already? You don't need to update to
> 0.6.0 if you need 0.5, I'm just asking to make sure you're working on the
> correct version to avoid more work.

It's a dependency that I'm unfortunately introducing in muvm
(https://github.com/AsahiLinux/muvm/pull/111), and 0.6.1 works just fine.


Spec URL: https://passt.top/static/rust-const-str-proc-macro.spec
SRPM URL: https://passt.top/static/rust-const-str-proc-macro-0.6.1-1.fc42.src.rpm
Description: Compile-time string operations
Fedora Account System Username: sbrivio

Created attachment 2074757 [details]
The .spec file difference from Copr build 8558146 to 8594544

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8594544
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2338679-rust-const-str-proc-macro/fedora-rawhide-x86_64/08594544-rust-const-str-proc-macro/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Thanks, looks good to me now!

Upstream released 0.6.2 in the meantime, if you can, update to that before importing the package.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
🫤 latest version of the crate is packaged (0.6.1 packaged, 0.6.2 is latest)
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

(In reply to Fabio Valentini from comment #12)
> Thanks, looks good to me now!

Thanks for checking!

> Upstream released 0.6.2 in the meantime, if you can, update to that before
> importing the package.

I will, definitely. It's just minor fixes and they don't break any dependency.

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-const-str-proc-macro

FEDORA-2025-494cad7668 (rust-const-str-proc-macro-0.6.2-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-494cad7668

FEDORA-2025-494cad7668 (rust-const-str-proc-macro-0.6.2-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.