Spec URL: https://passt.top/static/rust-const-str.spec SRPM URL: https://passt.top/static/rust-const-str-0.5.7-1.fc41.src.rpm Description: Compile-time string operations Fedora Account System Username: sbrivio
Copr build: https://copr.fedorainfracloud.org/coprs/build/8337277 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330150-rust-const-str/fedora-rawhide-x86_64/08337277-rust-const-str/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Nice of you to CC me here, but may I ask why? :D
(In reply to Fabio Valentini from comment #2) > Nice of you to CC me here, but may I ask why? :D Because I got a really nice review from you at https://bugzilla.redhat.com/show_bug.cgi?id=2329411#c6 about rust-neli-proc-macros, and I've seen that you're behind that rust2rpm magic... that's why. :)
The package builds successfully, but the built packages don't all install: Problem 1: conflicting requests - nothing provides (crate(const-str-proc-macro/default) >= 0.5.7 with crate(const-str-proc-macro/default) < 0.6.0~) needed by rust-const-str+case-devel-0.5.7-1.fc42.noarch from @commandline - nothing provides (crate(const-str-proc-macro/heck) >= 0.5.7 with crate(const-str-proc-macro/heck) < 0.6.0~) needed by rust-const-str+case-devel-0.5.7-1.fc42.noarch from @commandline (and several similar issues) It looks like some optional feature pulls in the const-str-proc-macro "companion" crate, which is not packaged yet. I recommend to use the "--postinstall" flag for local mock builds to catch issues like this early.
(In reply to Fabio Valentini from comment #4) > The package builds successfully, but the built packages don't all install: > > Problem 1: conflicting requests > - nothing provides (crate(const-str-proc-macro/default) >= 0.5.7 with > crate(const-str-proc-macro/default) < 0.6.0~) needed by > rust-const-str+case-devel-0.5.7-1.fc42.noarch from @commandline > - nothing provides (crate(const-str-proc-macro/heck) >= 0.5.7 with > crate(const-str-proc-macro/heck) < 0.6.0~) needed by > rust-const-str+case-devel-0.5.7-1.fc42.noarch from @commandline > (and several similar issues) > > It looks like some optional feature pulls in the const-str-proc-macro > "companion" crate, which is not packaged yet. Right. Review request for that now at https://bugzilla.redhat.com/show_bug.cgi?id=2338679. > I recommend to use the "--postinstall" flag for local mock builds to catch > issues like this early. Thanks for the tip, I didn't know.
Can you update this package to the 0.6.x branch too to match const-str-proc-macro?
(In reply to Fabio Valentini from comment #6) > Can you update this package to the 0.6.x branch too to match > const-str-proc-macro? Yes, I was just waiting for const-str-proc-macro to be available in mirrors, and it looks like it is now! 'mock --postinstall' (as you suggested) for this package finally works. So: Spec URL: https://passt.top/static/rust-const-str.spec SRPM URL: https://passt.top/static/rust-const-str-0.6.2-1.fc42.src.rpm
[fedora-review-service-build] Spec URL: https://passt.top/static/rust-const-str.spec SRPM URL: https://passt.top/static/rust-const-str-0.6.2-1.fc42.src.rpm Description: Compile-time string operations Fedora Account System Username: sbrivio
Created attachment 2077234 [details] The .spec file difference from Copr build 8337277 to 8675790
Copr build: https://copr.fedorainfracloud.org/coprs/build/8675790 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330150-rust-const-str/fedora-rawhide-x86_64/08675790-rust-const-str/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I'm sorry for the delay, this seems to have slipped between the cracks. The package looks good to me now, thank you for the update. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-const-str
FEDORA-2025-8e5455971c (rust-const-str-0.6.2-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-8e5455971c
(In reply to Fabio Valentini from comment #11) > I'm sorry for the delay, this seems to have slipped between the cracks. No worries, cracks are widespread. > The package looks good to me now, thank you for the update. Thanks for the review! Finally closing this.
FEDORA-2025-8e5455971c (rust-const-str-0.6.2-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.