Bug 234069

Summary:

ia64: validate mmap attributes (WB, UC, etc)

Product:

[Fedora] Fedora

Reporter:

Bjorn Helgaas <bjorn.helgaas>

Component:

kernel

Assignee:

Kernel Maintainer List <kernel-maint>

Status:

CLOSED DEFERRED

QA Contact:

Brian Brock <bbrock>

Severity:

medium

Docs Contact:

Priority:

medium

Version:

rawhide

CC:

prarit

Target Milestone:

---

Target Release:

---

Hardware:

ia64

OS:

Linux

Whiteboard:

Fixed In Version:

Doc Type:

Bug Fix

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2007-04-23 18:01:35 UTC

Type:

---

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Bug Depends On:

Bug Blocks:

163350

Attachments:

Description	Flags
backport ioremap_page_range()	none
use same variable names as i386	none
use ioremap_page_range() to avoid unsupported attributes	none
allow WB mmap of legacy_mem (for option ROMs)	none
fail mmaps that span incompatible attributes	none

Description Bjorn Helgaas 2007-03-26 20:55:07 UTC

ia64 kernel doesn't validate memory attributes (WB, UC, etc) correctly
for mmap of /dev/mem, /sys/.../legacy_mem, and reading /sys/.../rom.

Please incorporate the patches here:

https://enterprise.redhat.com/issue-tracker/?module=issues&action=view&tid=115881

Comment 1 Dave Jones 2007-04-04 04:37:44 UTC

please attach them directly to bugzilla. (Or better yet, get them upstream
before .21?)

Comment 2 Bjorn Helgaas 2007-04-04 15:27:20 UTC

Created attachment 151665 [details]
backport ioremap_page_range()

Tony put these changes in his test tree,so they will go upstream
shortly after 2.6.21.

Apply these in this order:

  ioremap
  ia64-ioremap-align
  ia64-ioremap
  ia64-legacy_mem-wb
  ia64-mmap-validation

Comment 3 Bjorn Helgaas 2007-04-04 15:28:08 UTC

Created attachment 151666 [details]
use same variable names as i386

Comment 4 Bjorn Helgaas 2007-04-04 15:29:05 UTC

Created attachment 151667 [details]
use ioremap_page_range() to avoid unsupported attributes

Comment 5 Bjorn Helgaas 2007-04-04 15:29:39 UTC

Created attachment 151668 [details]
allow WB mmap of legacy_mem (for option ROMs)

Comment 6 Bjorn Helgaas 2007-04-04 15:30:13 UTC

Created attachment 151669 [details]
fail mmaps that span incompatible attributes

Comment 7 Dave Jones 2007-04-04 21:05:14 UTC

Doesn't apply to Linus' latest tree.

+ echo 'Patch #400 (linux-2.6-backport-ioremap-page-range.patch):'
Patch #400 (linux-2.6-backport-ioremap-page-range.patch):
+ patch -p1 -s
1 out of 1 hunk FAILED -- saving rejects to file include/linux/io.h.rej
The next patch would create the file lib/ioremap.c,
which already exists!  Assume -R? [n] 


Looks like these are 2.6.18 patches?

Comment 8 Bjorn Helgaas 2007-04-04 22:50:14 UTC

These are against RHEL5.  What base would you like?

Comment 9 Prarit Bhargava 2007-04-04 23:05:59 UTC

(In reply to comment #8)
> These are against RHEL5.  What base would you like?

Seeing how this is a Fedora bug -- Fedora or upstream :)

P.

Comment 10 Dave Jones 2007-04-05 00:08:32 UTC

Fedora constantly tracks upstream. Right now, it's at 2.6.21rc5-git12 for example.

Comment 11 Bjorn Helgaas 2007-04-10 18:53:14 UTC

OK.  If Fedora tracks upstream closely, I don't think there's any
rush.  I'm happy to wait until Tony pushes them upstream and Fedora
updates to an upstream release that includes them.

I was under the mistaken impression that Fedora would be basically
a RHEL5 kernel with some new patches that might be candidates for
future RHEL5 updates.

If you want to close this as WONTFIX or DEFERRED or whatever, that's
fine with me.  Sorry for the distraction.