Bug 2342805

Summary:	Review Request: rust-trustfall_filetests_macros - Macros powering the trustfall project's filetests implementation
Product:	[Fedora] Fedora	Reporter:	Michel Lind <michel>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	POST ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	---	Flags:	decathorpe: fedora-review+
Hardware:	Unspecified
OS:	Unspecified
URL:	https://crates.io/crates/trustfall_filetests_macros
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michel Lind 2025-01-29 14:19:38 UTC

Spec URL: https://salimma.fedorapeople.org/rust-trustfall_filetests_macros.spec
SRPM URL: https://salimma.fedorapeople.org/rust-trustfall_filetests_macros-0.2.0-1.fc41.src.rpm

Description:
Macros powering the trustfall project's filetests implementation.

Fedora Account System Username: salimma

Comment 1 Michel Lind 2025-01-29 14:19:41 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=128608454

Comment 2 Fedora Review Service 2025-01-29 14:26:15 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8584439
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2342805-rust-trustfall_filetests_macros/fedora-rawhide-x86_64/08584439-rust-trustfall_filetests_macros/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2025-03-14 17:35:41 UTC

Same thing about being able to automate the missing license file with rust2rpm applies here, too.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass (there are no tests)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
🫤 license file is included with %license in %files (manually included, submitted fix to upstream)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)