Bug 2342805 - Review Request: rust-trustfall_filetests_macros - Macros powering the trustfall project's filetests implementation
Summary: Review Request: rust-trustfall_filetests_macros - Macros powering the trustfa...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/trustfall_fi...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-01-29 14:19 UTC by Michel Lind
Modified: 2026-06-16 16:37 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-06-16 16:37:47 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2025-01-29 14:19:38 UTC
Spec URL: https://salimma.fedorapeople.org/rust-trustfall_filetests_macros.spec
SRPM URL: https://salimma.fedorapeople.org/rust-trustfall_filetests_macros-0.2.0-1.fc41.src.rpm

Description:
Macros powering the trustfall project's filetests implementation.

Fedora Account System Username: salimma

Comment 1 Michel Lind 2025-01-29 14:19:41 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=128608454

Comment 2 Fedora Review Service 2025-01-29 14:26:15 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8584439
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2342805-rust-trustfall_filetests_macros/fedora-rawhide-x86_64/08584439-rust-trustfall_filetests_macros/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2025-03-14 17:35:41 UTC
Same thing about being able to automate the missing license file with rust2rpm applies here, too.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass (there are no tests)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
🫤 license file is included with %license in %files (manually included, submitted fix to upstream)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fabio Valentini 2026-03-13 21:54:05 UTC
Are you still interested in this package?

Comment 5 Michel Lind 2026-03-13 22:01:45 UTC
Yes please, let's set fedora-review to + again and I'll import

Comment 6 Fabio Valentini 2026-03-14 15:56:01 UTC
Done

Comment 7 Fabio Valentini 2026-04-29 14:38:34 UTC
*ping*

It's now been over a year since the initial approval. If you're really not that interested any more, please just close the ticket.

Comment 8 Michel Lind 2026-06-16 16:37:47 UTC
Per music, it's almost impossible to use this so let's just drop it


Note You need to log in before you can comment on or make changes to this bug.