Bug 234308

Summary: pam_tally faillog.h has a limited fail_line field.
Product: Red Hat Enterprise Linux 4 Reporter: Jose Plans <jplans>
Component: pamAssignee: Tomas Mraz <tmraz>
Status: CLOSED DUPLICATE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 4.4   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-03-28 13:39:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 234311    
Attachments:
Description Flags
pam-faillog_short_fail_line.patch none

Description Jose Plans 2007-03-28 13:18:53 UTC 
Description of problem:

When using faillog, the IP or hostname information gets truncated with strncpy()
on the 12 first characters due to the sizeof() from its definition.

Used the 52 present in rawhide. This is just part of the problem on write, read
(shadow-utils) need change as well for faillog to read it, since both have the
same header I'm sending a parallel bug blocker of this one against shadow-utils.

Version-Release number of selected component (if applicable):
pam-0.77-66.14

How reproducible:
Always

Steps to Reproduce:
1. Setup a pam stack to use pam_tally.so
2. Fail an authentication
  
Actual results:
fail line truncated.

Expected results:
At least the IP address.

Additional info:
patch from rawhide.
Comment 1 Jose Plans 2007-03-28 13:18:53 UTC 
Created attachment 151117 [details]
pam-faillog_short_fail_line.patch
Comment 2 Tomas Mraz 2007-03-28 13:39:19 UTC 
This cannot be changed due to breaking compatibility with existing faillog files.

The correct way is to backport pam_tally2.so from RHEL5.


*** This bug has been marked as a duplicate of 228044 ***