Bug 234308 - pam_tally faillog.h has a limited fail_line field.
pam_tally faillog.h has a limited fail_line field.
Status: CLOSED DUPLICATE of bug 228044
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: pam (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Tomas Mraz
Depends On:
Blocks: 234311
  Show dependency treegraph
Reported: 2007-03-28 09:18 EDT by Jose Plans
Modified: 2007-11-16 20:14 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-03-28 09:39:19 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
pam-faillog_short_fail_line.patch (559 bytes, patch)
2007-03-28 09:18 EDT, Jose Plans
no flags Details | Diff

  None (edit)
Description Jose Plans 2007-03-28 09:18:53 EDT
Description of problem:

When using faillog, the IP or hostname information gets truncated with strncpy()
on the 12 first characters due to the sizeof() from its definition.

Used the 52 present in rawhide. This is just part of the problem on write, read
(shadow-utils) need change as well for faillog to read it, since both have the
same header I'm sending a parallel bug blocker of this one against shadow-utils.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Setup a pam stack to use pam_tally.so
2. Fail an authentication
Actual results:
fail line truncated.

Expected results:
At least the IP address.

Additional info:
patch from rawhide.
Comment 1 Jose Plans 2007-03-28 09:18:53 EDT
Created attachment 151117 [details]
Comment 2 Tomas Mraz 2007-03-28 09:39:19 EDT
This cannot be changed due to breaking compatibility with existing faillog files.

The correct way is to backport pam_tally2.so from RHEL5.

*** This bug has been marked as a duplicate of 228044 ***

Note You need to log in before you can comment on or make changes to this bug.