Bug 234310

Summary: faillog doesn't show all the informations faillog.h
Product: Red Hat Enterprise Linux 4 Reporter: Jose Plans <jplans>
Component: shadow-utilsAssignee: Peter Vrabec <pvrabec>
Status: CLOSED WONTFIX QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.4   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-04-02 09:45:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 234311    
Attachments:
Description Flags
shadow-faillog_short_fail_line.patch none

Description Jose Plans 2007-03-28 13:21:05 UTC 
Description of problem:

When using faillog, the IP or hostname information gets truncated with strncpy()
on the 12 first characters due to the sizeof() from its definition.

Used the 52 present in rawhide. This is just part of the problem on write, read
(shadow-utils) need change as well for faillog to read it, since both have the
same header I'm sending a parallel bug blocker of this one against shadow-utils.

Version-Release number of selected component (if applicable):
shadow-utils-4.0.3-60.RHEL4

How reproducible:
Always

Steps to Reproduce:
1. Setup a pam stack to use pam_tally.so
2. Fail an authentication
3. Check with faillog
  
Actual results:
fail line truncated.

Expected results:
At least the IP address.

Additional info:
patch from rawhide.
Comment 1 Jose Plans 2007-03-28 13:21:05 UTC 
Created attachment 151118 [details]
shadow-faillog_short_fail_line.patch
Comment 2 Peter Vrabec 2007-04-02 09:45:47 UTC 
see #234311 comment #4