Bug 234310 - faillog doesn't show all the informations faillog.h
Summary: faillog doesn't show all the informations faillog.h
Alias: None
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: shadow-utils   
(Show other bugs)
Version: 4.4
Hardware: All
OS: Linux
Target Milestone: ---
: ---
Assignee: Peter Vrabec
QA Contact: David Lawrence
Depends On:
Blocks: 234311
TreeView+ depends on / blocked
Reported: 2007-03-28 13:21 UTC by Jose Plans
Modified: 2007-11-17 01:14 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-04-02 09:45:47 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
shadow-faillog_short_fail_line.patch (527 bytes, patch)
2007-03-28 13:21 UTC, Jose Plans
no flags Details | Diff

Description Jose Plans 2007-03-28 13:21:05 UTC
Description of problem:

When using faillog, the IP or hostname information gets truncated with strncpy()
on the 12 first characters due to the sizeof() from its definition.

Used the 52 present in rawhide. This is just part of the problem on write, read
(shadow-utils) need change as well for faillog to read it, since both have the
same header I'm sending a parallel bug blocker of this one against shadow-utils.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Setup a pam stack to use pam_tally.so
2. Fail an authentication
3. Check with faillog
Actual results:
fail line truncated.

Expected results:
At least the IP address.

Additional info:
patch from rawhide.

Comment 1 Jose Plans 2007-03-28 13:21:05 UTC
Created attachment 151118 [details]

Comment 2 Peter Vrabec 2007-04-02 09:45:47 UTC
see #234311 comment #4

Note You need to log in before you can comment on or make changes to this bug.