Bug 2344125
| Summary: | Review Request: rust-gst-plugin-uriplaylistbin - GStreamer playlist playback plugin | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yaakov Selkowitz <yselkowi> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | decathorpe:
fedora-review?
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://crates.io/crates/gst-plugin-uriplaylistbin | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Yaakov Selkowitz
2025-02-06 05:06:04 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8612384 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2344125-rust-gst-plugin-uriplaylistbin/fedora-rawhide-x86_64/08612384-rust-gst-plugin-uriplaylistbin/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Version 0.13.2 doesn't contain the LICENSE file for the MPL-2.0 license, which is (if I'm reading the license terms correctly) a requirement. This seems to have been fixed with version 0.13.5, so please update to that. Additionally, the same questions about 1) whether the Provides for the upstream project name were dropped accidentally and 2) whether you want to package now and enable tests later apply here, too. (In reply to Fabio Valentini from comment #2) > Version 0.13.2 doesn't contain the LICENSE file for the MPL-2.0 license, > which is (if I'm reading the license terms correctly) a requirement. This > seems to have been fixed with version 0.13.5, so please update to that. It didn't happen by itself. :-) > Additionally, the same questions about 1) whether the Provides for the > upstream project name were dropped accidentally and 2) whether you want to > package now and enable tests later apply here, too. As do my answers. Spec URL: https://yselkowitz.fedorapeople.org/rust-gst-plugin-uriplaylistbin.spec SRPM URL: https://yselkowitz.fedorapeople.org/rust-gst-plugin-uriplaylistbin-0.13.5-1.fc43.src.rpm Description: GStreamer playlist playback plugin Fedora Account System Username: yselkowitz Created attachment 2080488 [details]
The .spec file difference from Copr build 8612384 to 8772332
Copr build: https://copr.fedorainfracloud.org/coprs/build/8772332 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2344125-rust-gst-plugin-uriplaylistbin/fedora-rawhide-x86_64/08772332-rust-gst-plugin-uriplaylistbin/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package looks mostly good now except for the two points raised earlier (disabled tests could be enabled now, and Provides are missing, still not sure whether intentional or not). |