Spec URL: https://yselkowitz.fedorapeople.org/rust-gst-plugin-uriplaylistbin.spec SRPM URL: https://yselkowitz.fedorapeople.org/rust-gst-plugin-uriplaylistbin-0.13.2-1.fc42.src.rpm Description: GStreamer playlist playback plugin Fedora Account System Username: yselkowitz
Copr build: https://copr.fedorainfracloud.org/coprs/build/8612384 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2344125-rust-gst-plugin-uriplaylistbin/fedora-rawhide-x86_64/08612384-rust-gst-plugin-uriplaylistbin/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Version 0.13.2 doesn't contain the LICENSE file for the MPL-2.0 license, which is (if I'm reading the license terms correctly) a requirement. This seems to have been fixed with version 0.13.5, so please update to that. Additionally, the same questions about 1) whether the Provides for the upstream project name were dropped accidentally and 2) whether you want to package now and enable tests later apply here, too.
(In reply to Fabio Valentini from comment #2) > Version 0.13.2 doesn't contain the LICENSE file for the MPL-2.0 license, > which is (if I'm reading the license terms correctly) a requirement. This > seems to have been fixed with version 0.13.5, so please update to that. It didn't happen by itself. :-) > Additionally, the same questions about 1) whether the Provides for the > upstream project name were dropped accidentally and 2) whether you want to > package now and enable tests later apply here, too. As do my answers.
Spec URL: https://yselkowitz.fedorapeople.org/rust-gst-plugin-uriplaylistbin.spec SRPM URL: https://yselkowitz.fedorapeople.org/rust-gst-plugin-uriplaylistbin-0.13.5-1.fc43.src.rpm Description: GStreamer playlist playback plugin Fedora Account System Username: yselkowitz
Created attachment 2080488 [details] The .spec file difference from Copr build 8612384 to 8772332
Copr build: https://copr.fedorainfracloud.org/coprs/build/8772332 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2344125-rust-gst-plugin-uriplaylistbin/fedora-rawhide-x86_64/08772332-rust-gst-plugin-uriplaylistbin/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package looks mostly good now except for the two points raised earlier (disabled tests could be enabled now, and Provides are missing, still not sure whether intentional or not).
Please update to the latest version / v0.15 if you're still interested in this package. Alternatively, we could look into packaging gst-plugins-rs as-is from GitLab - no packages still use them via the Rust API, only via the GStreamer plugin interface. That would avoid having dozens of packages and we'd just have one source package and enable / disable plugins as-needed.
This comment was flagged as spam, view the edit history to see the original text if required.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.