Bug 2344721
| Summary: | Review Request: kxkb2locale1 - Allows switching keyboard layout in KDE livesys | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alessandro Astone <ales.astone> | ||||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | 8ru2u4gz, ngompa13, package-review | ||||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||
| Target Release: | --- | Flags: | ngompa13:
fedora-review+
|
||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://www.gnu.org/software/hello/ | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2025-02-12 18:19:21 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Alessandro Astone
2025-02-10 18:41:48 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8636528 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2344721-kxkb2locale1/fedora-rawhide-x86_64/08636528-kxkb2locale1/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://aleasto.fedorapeople.org/reviews/kxkb2locale1/kxkb2locale1.spec SRPM URL: https://aleasto.fedorapeople.org/reviews/kxkb2locale1/kxkb2locale1-0.1-1.src.rpm There seems to be some problem with the following file. SRPM URL: https://aleasto.fedorapeople.org/reviews/kxkb2locale1/kxkb2locale1-0.1-1.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://aleasto.fedorapeople.org/reviews/kxkb2locale1/kxkb2locale1.spec SRPM URL: https://aleasto.fedorapeople.org/reviews/kxkb2locale1/kxkb2locale1-0.1-1.fc43.src.rpm Created attachment 2075908 [details]
The .spec file difference from Copr build 8636528 to 8636547
Copr build: https://copr.fedorainfracloud.org/coprs/build/8636547 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2344721-kxkb2locale1/fedora-rawhide-x86_64/08636547-kxkb2locale1/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Created attachment 2075909 [details]
The .spec file difference from Copr build 8636547 to 8636587
Copr build: https://copr.fedorainfracloud.org/coprs/build/8636587 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2344721-kxkb2locale1/fedora-rawhide-x86_64/08636587-kxkb2locale1/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes:
* Package follows Fedora Packaging Guidelines
* Package uses KF6 packaging macros correctly
* Package builds and installs
* Package licensing is correct
* No serious issues from rpmlint
N.B.: I recommend adding "Supplements: (kwin-wayland%{?_isa} and livesys-scripts)" on import.
PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/kxkb2locale1 |