Bug 2344721 - Review Request: kxkb2locale1 - Allows switching keyboard layout in KDE livesys
Summary: Review Request: kxkb2locale1 - Allows switching keyboard layout in KDE livesys
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://www.gnu.org/software/hello/
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-02-10 18:41 UTC by Alessandro Astone
Modified: 2025-03-13 16:27 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-02-12 18:19:21 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 8636528 to 8636547 (597 bytes, patch)
2025-02-10 18:54 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 8636547 to 8636587 (1.43 KB, patch)
2025-02-10 19:07 UTC, Fedora Review Service
no flags Details | Diff

Description Alessandro Astone 2025-02-10 18:41:48 UTC
Spec URL: https://aleasto.fedorapeople.org/reviews/kxkb2locale1/kxkb2locale1.spec
SRPM URL: https://aleasto.fedorapeople.org/reviews/kxkb2locale1/kxkb2locale1-0.1-1.src.rpm
Description: Daemon that watches the KDE keyboard configuration and applies it to org.freedesktop.locale1
Fedora Account System Username: aleasto

Comment 1 Fedora Review Service 2025-02-10 18:43:34 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8636528
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2344721-kxkb2locale1/fedora-rawhide-x86_64/08636528-kxkb2locale1/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2025-02-10 18:48:58 UTC
There seems to be some problem with the following file.
SRPM URL: https://aleasto.fedorapeople.org/reviews/kxkb2locale1/kxkb2locale1-0.1-1.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fedora Review Service 2025-02-10 18:54:49 UTC
Created attachment 2075908 [details]
The .spec file difference from Copr build 8636528 to 8636547

Comment 6 Fedora Review Service 2025-02-10 18:54:51 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8636547
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2344721-kxkb2locale1/fedora-rawhide-x86_64/08636547-kxkb2locale1/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Alessandro Astone 2025-02-10 19:03:45 UTC
[fedora-review-service-build]

Comment 8 Fedora Review Service 2025-02-10 19:07:59 UTC
Created attachment 2075909 [details]
The .spec file difference from Copr build 8636547 to 8636587

Comment 9 Fedora Review Service 2025-02-10 19:08:01 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8636587
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2344721-kxkb2locale1/fedora-rawhide-x86_64/08636587-kxkb2locale1/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Neal Gompa 2025-02-10 20:13:15 UTC
Review notes:

* Package follows Fedora Packaging Guidelines
* Package uses KF6 packaging macros correctly
* Package builds and installs
* Package licensing is correct
* No serious issues from rpmlint

N.B.: I recommend adding "Supplements: (kwin-wayland%{?_isa} and livesys-scripts)" on import.

PACKAGE APPROVED.

Comment 11 Fedora Admin user for bugzilla script actions 2025-02-12 17:57:44 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/kxkb2locale1


Note You need to log in before you can comment on or make changes to this bug.