Bug 2346537 (rust-yuvutils-rs)

spec and srpm don't match. The copr build directory has a spec copy too, you could point to that rather than github which can drift

Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-yuvutils-rs/rust-yuvutils-rs.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08674700/rust-yuvutils-rs-0.8.1-1.src.rpm
Description: High performance utilities for YUV format handling and conversion
Fedora Account System Username: elmarco

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8675806
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2346537-rust-yuvutils-rs/fedora-rawhide-x86_64/08675806-rust-yuvutils-rs/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Build fails on i686:

   Compiling yuvutils-rs v0.8.1 (/builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1)
     Running `/usr/bin/rustc --crate-name yuvutils_rs --edition=2021 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --emit=dep-info,link -C opt-level=3 -C embed-bitcode=no -C codegen-units=1 -C debuginfo=2 --test --cfg 'feature="avx"' --cfg 'feature="default"' --cfg 'feature="rdm"' --cfg 'feature="sse"' --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values("avx", "big_endian", "default", "fast_mode", "geometry", "nightly_avx512", "nightly_f16", "nightly_i8mm", "professional_mode", "rayon", "rdm", "rdp", "sse"))' -C metadata=63009e1d1e7953ba -C extra-filename=-63009e1d1e7953ba --out-dir /builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1/target/rpm/deps -L dependency=/builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1/target/rpm/deps --extern num_traits=/builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1/target/rpm/deps/libnum_traits-4c8425876099cceb.rlib --extern rand=/builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1/target/rpm/deps/librand-77225dab0c6f3d72.rlib -Copt-level=3 -Cdebuginfo=2 -Ccodegen-units=1 -Cstrip=none -Clink-arg=-specs=/usr/lib/rpm/redhat/redhat-package-notes --cap-lints=warn`
error[E0432]: unresolved import `std::arch::x86_64`
   --> src/built_coefficients.rs:625:24
    |
625 |         use std::arch::x86_64::*;
    |                        ^^^^^^ could not find `x86_64` in `arch`
For more information about this error, try `rustc --explain E0432`.
error: could not compile `yuvutils-rs` (lib test) due to 1 previous error
Caused by:
  process didn't exit successfully: `/usr/bin/rustc --crate-name yuvutils_rs --edition=2021 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --emit=dep-info,link -C opt-level=3 -C embed-bitcode=no -C codegen-units=1 -C debuginfo=2 --test --cfg 'feature="avx"' --cfg 'feature="default"' --cfg 'feature="rdm"' --cfg 'feature="sse"' --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values("avx", "big_endian", "default", "fast_mode", "geometry", "nightly_avx512", "nightly_f16", "nightly_i8mm", "professional_mode", "rayon", "rdm", "rdp", "sse"))' -C metadata=63009e1d1e7953ba -C extra-filename=-63009e1d1e7953ba --out-dir /builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1/target/rpm/deps -L dependency=/builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1/target/rpm/deps --extern num_traits=/builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1/target/rpm/deps/libnum_traits-4c8425876099cceb.rlib --extern rand=/builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1/target/rpm/deps/librand-77225dab0c6f3d72.rlib -Copt-level=3 -Cdebuginfo=2 -Ccodegen-units=1 -Cstrip=none -Clink-arg=-specs=/usr/lib/rpm/redhat/redhat-package-notes --cap-lints=warn` (exit status: 1)
error: Bad exit status from /var/tmp/rpm-tmp.V74Cis (%check)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.V74Cis (%check)
Child return code was: 1


Also, please use rust2rpm.toml for the patch, and add a comment describing what patch is changing

Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-yuvutils-rs/rust-yuvutils-rs.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08677924/rust-yuvutils-rs-0.8.1-1.src.rpm
Description: High performance utilities for YUV format handling and conversion
Fedora Account System Username: elmarco

(the toml is normally alongside the spec on the github repo)

Builds on rawhide now, but installing all subrpms fails:

Failed to resolve the transaction:
Problem: conflicting requests
  - nothing provides (crate(fast_transpose/default) >= 0.2.3 with crate(fast_transpose/default) < 0.3.0~) needed by rust-yuvutils-rs+nightly_avx512-devel-0.8.1-1.fc43.noarch from @commandline
  - nothing provides (crate(fast_transpose/nightly_avx512) >= 0.2.3 with crate(fast_transpose/nightly_avx512) < 0.3.0~) needed by rust-yuvutils-rs+nightly_avx512-devel-0.8.1-1.fc43.noarch from @commandline
You can try to add to command line:
  --skip-broken to skip uninstallable packages


Also one small issue:
$ rust2rpm yuvutils-rs -s
WARNING: Extra patch '0001-Fix-test-build-on-i686.patch' might conflict with
         other patches in the future. Using patch numbers >= 2 is recommended.
• Generated: rust-yuvutils-rs.spec


Just bump patch number to `10` or so

Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-yuvutils-rs/rust-yuvutils-rs.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08697720/rust-yuvutils-rs-0.8.1-1.src.rpm
Description: High performance utilities for YUV format handling and conversion
Fedora Account System Username: elmarco

Created attachment 2077736 [details]
The .spec file difference from Copr build 8675806 to 8697723

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8697723
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2346537-rust-yuvutils-rs/fedora-rawhide-x86_64/08697723-rust-yuvutils-rs/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

+ spec + rust2rpm.toml looks good
+ builds on rawhide
+ installs on rawhide
+ content looks fine

setting fedora-review+

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-yuvutils-rs

FEDORA-2025-733f56d244 (rust-yuvutils-rs-0.8.1-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-733f56d244

FEDORA-2025-733f56d244 (rust-yuvutils-rs-0.8.1-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.