Bug 2346537 (rust-yuvutils-rs) - Review Request: rust-yuvutils-rs - High performance utilities for YUV format handling and conversion
Summary: Review Request: rust-yuvutils-rs - High performance utilities for YUV format ...
Keywords:
Status: CLOSED ERRATA
Alias: rust-yuvutils-rs
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Cole Robinson
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/yuvutils-rs
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-02-19 10:12 UTC by Marc-Andre Lureau
Modified: 2025-06-04 06:37 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-02-25 20:54:09 UTC
Type: ---
Embargoed:
crobinso: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 8675806 to 8697723 (999 bytes, patch)
2025-02-25 06:24 UTC, Fedora Review Service
no flags Details | Diff

Description Marc-Andre Lureau 2025-02-19 10:12:21 UTC
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-yuvutils-rs/rust-yuvutils-rs.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08671252/rust-yuvutils-rs-0.8.0-1.src.rpm
Description: High performance utilities for YUV format handling and conversion
Fedora Account System Username: elmarco

Comment 1 Cole Robinson 2025-02-19 19:49:35 UTC
spec and srpm don't match. The copr build directory has a spec copy too, you could point to that rather than github which can drift

Comment 2 Marc-Andre Lureau 2025-02-20 09:40:46 UTC
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-yuvutils-rs/rust-yuvutils-rs.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08674700/rust-yuvutils-rs-0.8.1-1.src.rpm
Description: High performance utilities for YUV format handling and conversion
Fedora Account System Username: elmarco

Comment 3 Fedora Review Service 2025-02-20 16:06:29 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8675806
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2346537-rust-yuvutils-rs/fedora-rawhide-x86_64/08675806-rust-yuvutils-rs/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Cole Robinson 2025-02-20 18:00:53 UTC
Build fails on i686:

   Compiling yuvutils-rs v0.8.1 (/builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1)
     Running `/usr/bin/rustc --crate-name yuvutils_rs --edition=2021 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --emit=dep-info,link -C opt-level=3 -C embed-bitcode=no -C codegen-units=1 -C debuginfo=2 --test --cfg 'feature="avx"' --cfg 'feature="default"' --cfg 'feature="rdm"' --cfg 'feature="sse"' --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values("avx", "big_endian", "default", "fast_mode", "geometry", "nightly_avx512", "nightly_f16", "nightly_i8mm", "professional_mode", "rayon", "rdm", "rdp", "sse"))' -C metadata=63009e1d1e7953ba -C extra-filename=-63009e1d1e7953ba --out-dir /builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1/target/rpm/deps -L dependency=/builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1/target/rpm/deps --extern num_traits=/builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1/target/rpm/deps/libnum_traits-4c8425876099cceb.rlib --extern rand=/builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1/target/rpm/deps/librand-77225dab0c6f3d72.rlib -Copt-level=3 -Cdebuginfo=2 -Ccodegen-units=1 -Cstrip=none -Clink-arg=-specs=/usr/lib/rpm/redhat/redhat-package-notes --cap-lints=warn`
error[E0432]: unresolved import `std::arch::x86_64`
   --> src/built_coefficients.rs:625:24
    |
625 |         use std::arch::x86_64::*;
    |                        ^^^^^^ could not find `x86_64` in `arch`
For more information about this error, try `rustc --explain E0432`.
error: could not compile `yuvutils-rs` (lib test) due to 1 previous error
Caused by:
  process didn't exit successfully: `/usr/bin/rustc --crate-name yuvutils_rs --edition=2021 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --emit=dep-info,link -C opt-level=3 -C embed-bitcode=no -C codegen-units=1 -C debuginfo=2 --test --cfg 'feature="avx"' --cfg 'feature="default"' --cfg 'feature="rdm"' --cfg 'feature="sse"' --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values("avx", "big_endian", "default", "fast_mode", "geometry", "nightly_avx512", "nightly_f16", "nightly_i8mm", "professional_mode", "rayon", "rdm", "rdp", "sse"))' -C metadata=63009e1d1e7953ba -C extra-filename=-63009e1d1e7953ba --out-dir /builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1/target/rpm/deps -L dependency=/builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1/target/rpm/deps --extern num_traits=/builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1/target/rpm/deps/libnum_traits-4c8425876099cceb.rlib --extern rand=/builddir/build/BUILD/rust-yuvutils-rs-0.8.1-build/yuvutils-rs-0.8.1/target/rpm/deps/librand-77225dab0c6f3d72.rlib -Copt-level=3 -Cdebuginfo=2 -Ccodegen-units=1 -Cstrip=none -Clink-arg=-specs=/usr/lib/rpm/redhat/redhat-package-notes --cap-lints=warn` (exit status: 1)
error: Bad exit status from /var/tmp/rpm-tmp.V74Cis (%check)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.V74Cis (%check)
Child return code was: 1


Also, please use rust2rpm.toml for the patch, and add a comment describing what patch is changing

Comment 5 Marc-Andre Lureau 2025-02-21 06:58:19 UTC
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-yuvutils-rs/rust-yuvutils-rs.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08677924/rust-yuvutils-rs-0.8.1-1.src.rpm
Description: High performance utilities for YUV format handling and conversion
Fedora Account System Username: elmarco

(the toml is normally alongside the spec on the github repo)

Comment 6 Cole Robinson 2025-02-24 21:04:26 UTC
Builds on rawhide now, but installing all subrpms fails:

Failed to resolve the transaction:
Problem: conflicting requests
  - nothing provides (crate(fast_transpose/default) >= 0.2.3 with crate(fast_transpose/default) < 0.3.0~) needed by rust-yuvutils-rs+nightly_avx512-devel-0.8.1-1.fc43.noarch from @commandline
  - nothing provides (crate(fast_transpose/nightly_avx512) >= 0.2.3 with crate(fast_transpose/nightly_avx512) < 0.3.0~) needed by rust-yuvutils-rs+nightly_avx512-devel-0.8.1-1.fc43.noarch from @commandline
You can try to add to command line:
  --skip-broken to skip uninstallable packages


Also one small issue:
$ rust2rpm yuvutils-rs -s
WARNING: Extra patch '0001-Fix-test-build-on-i686.patch' might conflict with
         other patches in the future. Using patch numbers >= 2 is recommended.
• Generated: rust-yuvutils-rs.spec


Just bump patch number to `10` or so

Comment 7 Marc-Andre Lureau 2025-02-25 06:12:22 UTC
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-yuvutils-rs/rust-yuvutils-rs.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08697720/rust-yuvutils-rs-0.8.1-1.src.rpm
Description: High performance utilities for YUV format handling and conversion
Fedora Account System Username: elmarco

Comment 8 Fedora Review Service 2025-02-25 06:24:26 UTC
Created attachment 2077736 [details]
The .spec file difference from Copr build 8675806 to 8697723

Comment 9 Fedora Review Service 2025-02-25 06:24:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8697723
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2346537-rust-yuvutils-rs/fedora-rawhide-x86_64/08697723-rust-yuvutils-rs/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Cole Robinson 2025-02-25 18:37:45 UTC
+ spec + rust2rpm.toml looks good
+ builds on rawhide
+ installs on rawhide
+ content looks fine

setting fedora-review+

Comment 11 Fedora Admin user for bugzilla script actions 2025-02-25 19:10:17 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-yuvutils-rs

Comment 12 Fedora Update System 2025-02-25 19:23:20 UTC
FEDORA-2025-733f56d244 (rust-yuvutils-rs-0.8.1-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-733f56d244

Comment 13 Fedora Update System 2025-02-25 20:54:09 UTC
FEDORA-2025-733f56d244 (rust-yuvutils-rs-0.8.1-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.